Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric graphs on cronjob, job and pod list pages. #4465

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Add metric graphs on cronjob, job and pod list pages. #4465

merged 2 commits into from
Oct 31, 2019
+28 −6

Conversation

wjywbs
Copy link
Contributor

@wjywbs wjywbs commented Oct 26, 2019 •
edited
Loading

Part of #3866.

@wjywbs
Add metric graphs on cronjob, job and pod list pages.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3a453f2
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2019
@wjywbs
Copy link
Contributor Author

wjywbs commented Oct 26, 2019

/assign @maciaszczykm

@codecov
Copy link

codecov bot commented Oct 26, 2019 •
edited
Loading

Codecov Report

Merging #4465 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4465   +/-   ##
======================================
  Coverage    46.7%   46.7%           
======================================
  Files         200     200           
  Lines        9373    9373           
  Branches      107     107           
======================================
  Hits         4378    4378           
  Misses       4721    4721           
  Partials      274     274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23c3a8...a922567. Read the comment docs.

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, wjywbs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 83f14ff into kubernetes:master Oct 31, 2019
@wjywbs wjywbs deleted the graph branch October 31, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielromlein danielromlein

@ianlewis ianlewis

Assignees

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjywbs @maciaszczykm @k8s-ci-robot