Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph display when values in series have different suffixes #4637

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

floreks
Copy link
Member

@floreks floreks commented Dec 5, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@floreks floreks self-assigned this Dec 5, 2019
@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #4637 into master will increase coverage by 0.2%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4637     +/-   ##
=========================================
+ Coverage   45.22%   45.42%   +0.2%     
=========================================
  Files         214      214             
  Lines        9987     9978      -9     
  Branches      106       96     -10     
=========================================
+ Hits         4517     4533     +16     
+ Misses       5205     5180     -25     
  Partials      265      265
Impacted Files Coverage Δ
src/app/frontend/common/components/graph/helper.ts 60.97% <60%> (+29.49%) ⬆️
.../app/frontend/common/components/graph/component.ts 76.78% <63.63%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5c999...be05b0c. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit c1d81d1 into kubernetes:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants