-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi locales in one translation file #4814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4814 +/- ##
==========================================
- Coverage 45.43% 45.42% -0.02%
==========================================
Files 214 214
Lines 9977 9977
Branches 94 94
==========================================
- Hits 4533 4532 -1
- Misses 5180 5181 +1
Partials 264 264
Continue to review full report at Codecov.
|
I am not sure if creating a symbolic link is a correct way of doing this. Every translation file in the header has information about
If we create a symbolic link to a different language code, then |
We can use Firefox and Chrome don't seem to have It has inconsistent in I'll investigate how not to build /hold |
a1edf03
to
1dbcf03
Compare
/hold cancel |
1dbcf03
to
eb6961c
Compare
This may not be the right way. |
eb6961c
to
d48306d
Compare
/hold |
@hwdef, how about |
@shu-mutou |
@hwdef I got it. I'll make |
`zh` is same as `zh-cn`, so maintain `zh` and change `zh-cn` to link to `zh`. Also, added support for `i18n/locales_not_for_build_local` that keeps locales not for build as local setting for developer. Because building dashboard takes much time.
d48306d
to
f093ae8
Compare
@floreks Changes for this PR are coming back to first situation and inconsistency in |
/hold cancel |
I am not fully sure if keeping target locale that is different than configured locale code will not cause some issues during compiling the translated versions. Having multiple overlapping target languages might cause issues. |
@floreks No worry, I think. Dashboard is built with In fact, |
@shu-mutou makes sense. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zh
is same aszh-cn
, so maintainzh
and changezh-cn
as link tozh
.Also, added support for
i18n/locales_not_for_build_local
that keeps locales not for build as local setting for developer. Because building dashboard takes much time.Ref: #4734 comment
Ref: #4763