-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment curl #4817
comment curl #4817
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4817 +/- ##
=======================================
Coverage 45.43% 45.43%
=======================================
Files 214 214
Lines 9977 9977
Branches 94 94
=======================================
Hits 4533 4533
Misses 5180 5180
Partials 264 264 Continue to review full report at Codecov.
|
Signed-off-by: Xiang Dai <764524258@qq.com>
Please add curl to the top as required dependency. |
@floreks done |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daixiang0, floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xiang Dai 764524258@qq.com
If there is no
golangci-cli
orcurl
, build would fail: