Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update HPA translation #4856

Merged
merged 1 commit into from
Feb 4, 2020
Merged

update HPA translation #4856

merged 1 commit into from
Feb 4, 2020

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Feb 4, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@hwdef hwdef mentioned this pull request Feb 4, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the language/zh Updates or issues for Chinese translations. label Feb 4, 2020
@hwdef hwdef requested a review from tanjunchen February 4, 2020 02:26
zehuaiWANG
zehuaiWANG reviewed Feb 4, 2020
View reviewed changes
i18n/zh/messages.zh.xlf Outdated
<context-group purpose="location">
<context context-type="sourcefile">../src/app/frontend/common/components/resourcelist/horizontalpodautoscaler/template.html</context>
<context context-type="linenumber">58</context>
</context-group>
</trans-unit>
<trans-unit id="db972eb77504c0dfc832ecb36168c5b64ab6d30b" datatype="html">
<source>Max Replicas</source>
<target state="new">Max Replicas</target>
<target state="new">最小副本数</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最大副本数

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刚发现了，改完了。

@codecov
Copy link

codecov bot commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #4856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4856   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files         214      214           
  Lines        9978     9978           
  Branches       94       94           
=======================================
  Hits         4533     4533           
  Misses       5180     5180           
  Partials      265      265

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009efbd...f8679fc. Read the comment docs.

@shu-mutou
Copy link
Contributor

Don't you translate i18n/zh-sg/messages.zh-sg.xlf?

@shu-mutou shu-mutou mentioned this pull request Feb 4, 2020
Closed
11 tasks
@hwdef
Copy link
Member Author

hwdef commented Feb 4, 2020 •
edited
Loading

@shu-mutou
The current reviewer does not know about zh-sg.
I think We temporarily link zh-sg to zh is better.@zehuaiWANG said they were not much different
WDYT?

@shu-mutou
Copy link
Contributor

@hwdef There is no particular reason to object, so create a symbolic link as shown below and submit PR.

cd i18n/zh-sg/
rm messages.zh-sg.xlf
ln -s ../zh/messages.zh.xlf messages.zh-sg.xlf

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2020
@hwdef
Copy link
Member Author

hwdef commented Feb 4, 2020

@shu-mutou
Thanks for you help.
Please review this again.

@shu-mutou
Copy link
Contributor

@hwdef I'm sorry forgetting onemore thing. Could you remove zh-cn and zh-sg from xliffmergeOptions in package.json.

@hwdef
Copy link
Member Author

hwdef commented Feb 4, 2020

@shu-mutou
done

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@shu-mutou
Copy link
Contributor

/lgtm
@hwdef Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 922a761 into kubernetes:master Feb 4, 2020
@hwdef hwdef deleted the update-zh-trans1 branch May 26, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehuaiWANG zehuaiWANG zehuaiWANG left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@danielromlein danielromlein Awaiting requested review from danielromlein

@tanjunchen tanjunchen Awaiting requested review from tanjunchen

Assignees

@shu-mutou shu-mutou

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwdef @shu-mutou @k8s-ci-robot @zehuaiWANG