Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n/ko translation bug #4859

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

seokho-son
Copy link
Member

This PR fixes a bug in i18n/ko/messages.ko.xlf.
(bug: A translated content was misplaced and this bug keep generated empty lines.)

cc @shu-mutou

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2020
@k8s-ci-robot k8s-ci-robot added the language/ko Updates or issues for Korean translations. label Feb 4, 2020
@shu-mutou
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #4859 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4859      +/-   ##
==========================================
+ Coverage   45.39%   45.42%   +0.03%     
==========================================
  Files         214      214              
  Lines        9978     9978              
  Branches       94       94              
==========================================
+ Hits         4530     4533       +3     
+ Misses       5184     5180       -4     
- Partials      264      265       +1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 73.26% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571fa69...c755a6a. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 8adb2e0 into kubernetes:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants