-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide German translation. #4905
Conversation
Welcome @headcr4sh! |
bd8d737
to
4980693
Compare
Codecov Report
@@ Coverage Diff @@
## master #4905 +/- ##
==========================================
- Coverage 45.35% 45.35% -0.01%
==========================================
Files 214 214
Lines 10001 10000 -1
Branches 97 97
==========================================
- Hits 4536 4535 -1
Misses 5199 5199
Partials 266 266
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks really good, some comments though 😃
Thanks for the feedback, @kgroschoff . (I hope that force-pushing is the way that you prefer as I think that a bunch of "correction commits" are not really useful in the case of adding a new translation...) |
Could you find someone who become approver? Because dashboard approvers can not review each translations. It may be good asking help to kubernetes-docs-de channel in k8s slack. |
Sure. I just asked in #kubernetes-docs-de ... |
let's see if I can assign me on this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reached yet 1161, will proceed soon
I have incorporated your feedback so far and force-pushed onto my re-based PR branch. |
@headcr4sh @mkorbi @kgroschoff If you guys can become approvers for German translation with responsibility, please add your github accounts into OWNERS file. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: headcr4sh, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is my first contribution to the Kubernetes Dashboard. I'll gladly review any other changes to the German translation. If someone can add my handle to the |
If you guys can become approvers and organize German translation team, please submit PR to add you guys into OWNERS file. Plural approvers are preferable. We would approve your PR. 😄 |
No description provided.