Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide German translation. #4905

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

headcr4sh
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @headcr4sh!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 13, 2020
@headcr4sh headcr4sh force-pushed the i18n-de branch 2 times, most recently from bd8d737 to 4980693 Compare February 13, 2020 21:25
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4905 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4905      +/-   ##
==========================================
- Coverage   45.35%   45.35%   -0.01%     
==========================================
  Files         214      214              
  Lines       10001    10000       -1     
  Branches       97       97              
==========================================
- Hits         4536     4535       -1     
  Misses       5199     5199              
  Partials      266      266
Impacted Files Coverage Δ
src/app/frontend/polyfills.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4167b31...1d52813. Read the comment docs.

Copy link

@kgroschoff kgroschoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks really good, some comments though 😃

@headcr4sh
Copy link
Contributor Author

Overall it looks really good, some comments though 😃

Thanks for the feedback, @kgroschoff .
I have gone through all your feedback and updated my commit by force-pushing onto my PR-branch.

(I hope that force-pushing is the way that you prefer as I think that a bunch of "correction commits" are not really useful in the case of adding a new translation...)

@shu-mutou
Copy link
Contributor

Could you find someone who become approver? Because dashboard approvers can not review each translations. It may be good asking help to kubernetes-docs-de channel in k8s slack.

@shu-mutou shu-mutou added the language/de Updates or issues for German translations. label Feb 15, 2020
@headcr4sh
Copy link
Contributor Author

headcr4sh commented Feb 15, 2020

Could you find someone who become approver? Because dashboard approvers can not review each translations. It may be good asking help to kubernetes-docs-de channel in k8s slack.

Sure. I just asked in #kubernetes-docs-de ...

@mkorbi
Copy link

mkorbi commented Feb 16, 2020

let's see if I can assign me on this :)
/assign @mkorbi

Copy link

@mkorbi mkorbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reached yet 1161, will proceed soon

@headcr4sh
Copy link
Contributor Author

headcr4sh commented Feb 16, 2020

Just reached yet 1161, will proceed soon

I have incorporated your feedback so far and force-pushed onto my re-based PR branch.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shu-mutou
Copy link
Contributor

@headcr4sh @mkorbi @kgroschoff If you guys can become approvers for German translation with responsibility, please add your github accounts into OWNERS file.

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: headcr4sh, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9c7c72b into kubernetes:master Feb 17, 2020
@headcr4sh
Copy link
Contributor Author

@headcr4sh @mkorbi @kgroschoff If you guys can become approvers for German translation with responsibility, please add your github accounts into OWNERS file.

This is my first contribution to the Kubernetes Dashboard. I'll gladly review any other changes to the German translation. If someone can add my handle to the OWNERS file, I will participate in future translation reviews.

@shu-mutou
Copy link
Contributor

If you guys can become approvers and organize German translation team, please submit PR to add you guys into OWNERS file. Plural approvers are preferable. We would approve your PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants