Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ANSI color codes to logged terminal output. #4963

Merged
merged 5 commits into from
Feb 29, 2020

Conversation

greggbjensen
Copy link
Contributor

.NET Core outputs ANSI color codes for it's standard logging, and these are not currently translated. This leads to output that contains unprintable characters.

image

Adding support for ANSI color codes will allow for more readable logs, and consistent support for .NET Core as well as other applications.

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2020
package.json Outdated Show resolved Hide resolved
src/app/frontend/common/pipes/safehtml.ts Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fbed1fe). Click here to learn what that means.
The diff coverage is 70.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4963   +/-   ##
=========================================
  Coverage          ?   45.43%           
=========================================
  Files             ?      214           
  Lines             ?    10047           
  Branches          ?       96           
=========================================
  Hits              ?     4565           
  Misses            ?     5215           
  Partials          ?      267
Impacted Files Coverage Δ
src/app/frontend/index.config.ts 100% <ø> (ø)
...ntend/common/components/chips/chipdialog/dialog.ts 62.5% <100%> (ø)
.../app/frontend/common/components/chips/component.ts 75.75% <100%> (ø)
src/app/frontend/polyfills.ts 100% <100%> (ø)
src/app/frontend/common/services/global/assets.ts 95% <100%> (ø)
src/app/frontend/shared.module.ts 100% <100%> (ø)
src/app/frontend/common/pipes/safehtml.ts 42.85% <27.27%> (ø)
src/app/backend/handler/localehandler.go 56.94% <43.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbed1fe...4b4a3ad. Read the comment docs.

@greggbjensen greggbjensen requested a review from floreks February 28, 2020 19:47
@floreks
Copy link
Member

floreks commented Feb 29, 2020

It should be safe, given that we trust ansi library to be fully safe. Thanks for this fix!

@floreks
Copy link
Member

floreks commented Feb 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, greggbjensen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5a756b1 into kubernetes:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants