-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ANSI color codes to logged terminal output. #4963
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4963 +/- ##
=========================================
Coverage ? 45.43%
=========================================
Files ? 214
Lines ? 10047
Branches ? 96
=========================================
Hits ? 4565
Misses ? 5215
Partials ? 267
Continue to review full report at Codecov.
|
It should be safe, given that we trust ansi library to be fully safe. Thanks for this fix! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, greggbjensen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.NET Core outputs ANSI color codes for it's standard logging, and these are not currently translated. This leads to output that contains unprintable characters.
Adding support for ANSI color codes will allow for more readable logs, and consistent support for .NET Core as well as other applications.