Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation #5029

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

seokho-son
Copy link
Member

This PR updates Korean translation (i18n/ko/messages.ko.xlf) for the following changes.

(Related root issue: #4259)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from gochist and PeWu March 25, 2020 09:06
@k8s-ci-robot k8s-ci-robot added language/ko Updates or issues for Korean translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2020
@seokho-son
Copy link
Member Author

@gochist This PR needs a review from Korean expert :)

@gochist
Copy link
Member

gochist commented Mar 25, 2020

/retest

@shu-mutou
Copy link
Contributor

@seokho-son @gochist I've Restart job on Travis and tests are passed. Could you start review?

@gochist
Copy link
Member

gochist commented Mar 26, 2020

@seokho-son @shu-mutou Thank you!!!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d50ed9 into kubernetes:master Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5029 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5029      +/-   ##
==========================================
+ Coverage   45.41%   45.42%   +<.01%     
==========================================
  Files         214      214              
  Lines       10078    10078              
  Branches      100      100              
==========================================
+ Hits         4577     4578       +1     
+ Misses       5233     5232       -1     
  Partials      268      268
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b24fe1...863697d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants