Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inactive members from OWNERS #5359

Merged
merged 5 commits into from
Jul 16, 2020
Merged

Conversation

jeefy
Copy link
Member

@jeefy jeefy commented Jul 11, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2020
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #5359 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5359      +/-   ##
==========================================
- Coverage   45.46%   45.45%   -0.01%     
==========================================
  Files         214      214              
  Lines       10208    10208              
  Branches      108      108              
==========================================
- Hits         4641     4640       -1     
  Misses       5293     5293              
- Partials      274      275       +1     
Impacted Files Coverage Δ
src/app/frontend/login/component.ts 81.25% <0.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c58446...f058c19. Read the comment docs.

@maciaszczykm
Copy link
Member

Looks good to me. IIRC @konryd and @danielromlein are also inactive.

@floreks do you have any input?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2020
@floreks
Copy link
Member

floreks commented Jul 13, 2020

I'd propose to do a full cleanup. Most people are already inactive for at least a year or more.

@floreks
Copy link
Member

floreks commented Jul 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, jeefy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87bd00b into kubernetes:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants