Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test #6027

Closed
wants to merge 2 commits into from
Closed

Fix e2e test #6027

wants to merge 2 commits into from

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Apr 26, 2021

Increase fs.inotify.max_user_watches for cypress file watcher.

E2E test does not result error, but tons of Error: ENOSPC: System limit for number of file watchers reached occur.
Ref: cypress-io/cypress#4283 (comment)

Increase fs.inotify.max_user_watches for cypress file watcher.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from floreks and jeefy April 26, 2021 08:26
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #6027 (be3c840) into master (3a5dbbe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6027   +/-   ##
=======================================
  Coverage   41.97%   41.97%           
=======================================
  Files         216      216           
  Lines        9329     9329           
  Branches      155      155           
=======================================
  Hits         3916     3916           
  Misses       5162     5162           
  Partials      251      251           

@floreks
Copy link
Member

floreks commented Apr 26, 2021

Already did that: https://github.com/kubernetes/dashboard/pull/6014/files#diff-e42b2b9794d0333e41c8e218ece5897ea7395746b5e07d08fb85b53e36d15043R160 🙂

@shu-mutou
Copy link
Contributor Author

Great 😄

/close

@k8s-ci-robot
Copy link
Contributor

@shu-mutou: Closed this PR.

In response to this:

Great 😄

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shu-mutou shu-mutou deleted the fix-e2e branch August 11, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants