Feat/spanish localization

[anyulled]

Spanish translation of the Dashboard UI

Followed instructions on Internationalization

resolves #6582

[k8s-ci-robot]

Welcome @anyulled!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[floreks]

Please, extend also the supported languages list in the code.

dashboard/src/app/frontend/index.config.ts

Lines 19 to 52 in 5106f87

	const supportedLanguages: LanguageConfig[] = [
	{
	label: 'German',
	value: 'de',
	},
	{
	label: 'French',
	value: 'fr',
	},
	{
	label: 'English',
	value: 'en',
	},
	{
	label: 'Japanese',
	value: 'ja',
	},
	{
	label: 'Korean',
	value: 'ko',
	},
	{
	label: 'Chinese Simplified',
	value: 'zh-Hans',
	},
	{
	label: 'Chinese Traditional',
	value: 'zh-Hant',
	},
	{
	label: 'Chinese Traditional Hong Kong',
	value: 'zh-Hant-HK',
	},
	];

[anyulled]

Please, extend also the supported languages list in the code.

dashboard/src/app/frontend/index.config.ts

Lines 19 to 52 in 5106f87

	const supportedLanguages: LanguageConfig[] = [
	{
	label: 'German',
	value: 'de',
	},
	{
	label: 'French',
	value: 'fr',
	},
	{
	label: 'English',
	value: 'en',
	},
	{
	label: 'Japanese',
	value: 'ja',
	},
	{
	label: 'Korean',
	value: 'ko',
	},
	{
	label: 'Chinese Simplified',
	value: 'zh-Hans',
	},
	{
	label: 'Chinese Traditional',
	value: 'zh-Hant',
	},
	{
	label: 'Chinese Traditional Hong Kong',
	value: 'zh-Hant-HK',
	},
	];

Sure, this change needs to be referenced in the internalization page too

[floreks]

@anyulled if you'd like to add a short sentence about this requirement there it would be great.

[anyulled]

As part of the internationalization documentation, it says that I could set myself as an OWNER of this section in order to watch the changes. To be able to do that, I need to be part of the Kubernetes community. Would any of you @raelga @floreks @maciaszczykm please sponsor me to be part of the community?

Otherwise, I could remove myself from the OWNERS file

[raelga]

Thanks @anyulled, working on the review as it's a quite extensive document :p

[raelga]

And about becoming a Kubernetes member, count with my endorsement. 👍🏻

[shu-mutou]

@anyulled, could you rebase and add yourself to OWNERS file?
@raelga, could you review i18n/es/messages.es.xlf?

[codecov]

Codecov Report

Merging #6587 (2738e30) into master (34b8d11) will decrease coverage by 0.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6587      +/-   ##
==========================================
- Coverage   42.55%   41.82%   -0.74%     
==========================================
  Files         217       44     -173     
  Lines       10644     1241    -9403     
  Branches      177      179       +2     
==========================================
- Hits         4530      519    -4011     
+ Misses       5851      683    -5168     
+ Partials      263       39     -224     

[anyulled]

hi, @shu-mutou I'm afraid I don't have an approver role in the project, I added myself in the past and the @k8s-ci-robot added the label do-not-merge/invalid-owners-file.

I'll try in the future if my role gets upgraded

[shu-mutou]

You have been already k8s community member, so I think it's ok to add yourself to OWNERS file. Could you try it again?

[anyulled]

You have already been a k8s community member, so I think it's ok to add yourself to the OWNERS file. Could you try it again?

It worked! thanks, now we're missing the LGTM & approved labels and we're good to go.

[gamba47]

@anyulled looks fine to me.

[shu-mutou]

Multiple approvers are preferred because the approver can't approve yourself.

[shu-mutou]

Also, dashboard maintainer can not review each languages.

[raelga]

Suggested change

	- electrocucaracha

@electrocucaracha mind joining as approver?

[shu-mutou]

Some new untranslated words have been added into i18n/messages.xlf during review.
Could you merge them into i18n/es/messages.es.xlf using npm fix and translate them?

[shu-mutou]

Before conflict occur, merge this once.
Please keep to invite reviewers and update your translations in the new PR.

[shu-mutou]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anyulled, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anyulled]

Many thanks @shu-mutou @gamba47 @raelga @floreks @maciaszczykm !