Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation (lines 1001-1500) #7427

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

rollony
Copy link
Contributor

@rollony rollony commented Sep 7, 2022

from #7424

Update on lines 1001-1500

  • Changed <target state="new"> to <target>
  • Translated strings to Korean, between <target state="new">Strings to translate</target>

Followed https://kubernetes.io/ko/docs/contribute/localization_ko for translating to Korean terms.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Updates or issues for Korean translations. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @rollony!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2022
@seokho-son
Copy link
Member

Hi @shu-mutou
Could you approve running workflows for this PR ?

@rollony is a first-time contributor of this repo.
(I've invited several new contributors from #7427 . They will open PRs for Korean localization tasks)

@shu-mutou
Copy link
Contributor

@rollony welcome!!
@seokho-son pleasure!

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #7427 (08adfc0) into master (67fbde9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7427   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38           

@seokho-son
Copy link
Member

Thank you @rollony

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rollony, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8ab6bb0 into kubernetes:master Sep 7, 2022
Seo-yul added a commit to Seo-yul/kubernetes-dashboard that referenced this pull request Sep 7, 2022
Seo-yul added a commit to Seo-yul/kubernetes-dashboard that referenced this pull request Sep 8, 2022
Apply suggestions from code review

I accept suggestions

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Yoon Seo-yul <devops.reso@gmail.com>
k8s-ci-robot pushed a commit that referenced this pull request Sep 9, 2022
Apply suggestions from code review

I accept suggestions

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Yoon Seo-yul <devops.reso@gmail.com>

Signed-off-by: Yoon Seo-yul <devops.reso@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants