Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Korean localization #7514

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

jc01rho
Copy link
Contributor

@jc01rho jc01rho commented Nov 1, 2022

Update of the some missing translated texts.

Update of the some missing translated texts.


Signed-off-by: jc01rho <rkjnice@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jc01rho / name: jc01rho (45ba158)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jc01rho!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ko Updates or issues for Korean translations. labels Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 1, 2022
@seokho-son
Copy link
Member

Hi @shu-mutou
Could you enable workflows for this PR from @jc01rho who is a first-time contributor ?

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #7514 (45ba158) into master (7c78264) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 45ba158 differs from pull request most recent head 9b8bfe4. Consider uploading reports for the commit 9b8bfe4 to get more accurate results

@@           Coverage Diff           @@
##           master    #7514   +/-   ##
=======================================
  Coverage   42.07%   42.08%           
=======================================
  Files         217      217           
  Lines       12084    12084           
  Branches      179      179           
=======================================
+ Hits         5084     5085    +1     
+ Misses       6716     6715    -1     
  Partials      284      284           

Signed-off-by: jc01rho <rkjnice@gmail.com>
@seokho-son
Copy link
Member

seokho-son commented Nov 23, 2022

Thanks @jc01rho

/lgtm

(a maintainer needs to enable running workflows)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jc01rho, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0ae795b into kubernetes:master Nov 23, 2022
@jc01rho jc01rho deleted the patch-1 branch November 30, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants