Fix Scale Resource UI #7584
Merged
Fix Scale Resource UI #7584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #7584 +/- ##
==========================================
+ Coverage 42.08% 42.10% +0.02%
==========================================
Files 217 217
Lines 12084 12084
Branches 179 179
==========================================
+ Hits 5085 5088 +3
+ Misses 6715 6711 -4
- Partials 284 285 +1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, marcosdiez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback UI for the
Scale a Resourcepanel was wrong, therefore it was not showing the correct number ofactual replicas.This PR fixed that. And since I am only deleting code, I am technically increasing our test coverage :)