Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update helm deployment #7969

Merged
merged 12 commits into from
Jul 7, 2023
Merged

feat: Update helm deployment #7969

merged 12 commits into from
Jul 7, 2023

Conversation

floreks
Copy link
Member

@floreks floreks commented Jun 30, 2023

Tested on GKE and local kind cluster. Access using kubectl port-forward -n kubernetes-dashboard svc/kubernetes-dashboard-nginx-controller 8443:443.

TODO:

  • Update NOTES.txt
  • Update helm installation info
  • Update docs

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2023
@floreks floreks self-assigned this Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2023
@floreks floreks changed the title wip: Update helm ingress configuration wip: Update helm deployment Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #7969 (9798253) into master (cd62237) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7969      +/-   ##
==========================================
- Coverage   42.16%   42.05%   -0.11%     
==========================================
  Files         218      164      -54     
  Lines       12099    10913    -1186     
  Branches      179        0     -179     
==========================================
- Hits         5101     4590     -511     
+ Misses       6714     6063     -651     
+ Partials      284      260      -24     

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2023
@floreks floreks changed the title wip: Update helm deployment feat: Update helm deployment Jul 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floreks floreks merged commit d6c217d into kubernetes:master Jul 7, 2023
15 of 16 checks passed
@floreks floreks deleted the update/helm branch July 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants