Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add full proxy mode to api module #8766

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 8, 2024

Ensure that there are no in-cluster client calls when running in proxy mode.

@floreks floreks self-assigned this Mar 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2024
@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2024
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #8766 (7b15284) into master (dbe7a46) will decrease coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 12.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8766      +/-   ##
==========================================
- Coverage   35.64%   35.59%   -0.05%     
==========================================
  Files         255      255              
  Lines       10770    10782      +12     
  Branches      158      142      -16     
==========================================
- Hits         3839     3838       -1     
- Misses       6680     6731      +51     
+ Partials      251      213      -38     

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@floreks floreks added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@floreks floreks merged commit a370d5b into master Mar 8, 2024
21 checks passed
@floreks floreks deleted the api/proxy-mode branch March 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants