-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): role/clusterole/podlist endpoints #8881
Conversation
floreks
commented
Apr 5, 2024
- fix role/clusterole list from all namespaces endpoint
- improve logging when metrics are disabled
- add container status list to pod list
…led and add container statuses to pod list
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8881 +/- ##
==========================================
+ Coverage 37.50% 37.63% +0.12%
==========================================
Files 255 256 +1
Lines 11155 11186 +31
Branches 157 158 +1
==========================================
+ Hits 4184 4210 +26
- Misses 6720 6763 +43
+ Partials 251 213 -38 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
…430) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-dashboard](https://togithub.com/kubernetes/dashboard) | minor | `7.1.3` -> `7.2.0` | --- ### Release Notes <details> <summary>kubernetes/dashboard (kubernetes-dashboard)</summary> ### [`v7.2.0`](https://togithub.com/kubernetes/dashboard/releases/tag/kubernetes-dashboard-7.2.0) [Compare Source](https://togithub.com/kubernetes/dashboard/compare/kubernetes-dashboard-7.1.3...kubernetes-dashboard-7.2.0) #### What's Changed - ci: Fix CodeQL check and ignore codecov token error by [@​shu-mutou](https://togithub.com/shu-mutou) in [https://github.com/kubernetes/dashboard/pull/8827](https://togithub.com/kubernetes/dashboard/pull/8827) - chore(deps-dev): bump cypress from 13.6.6 to 13.7.1 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8825](https://togithub.com/kubernetes/dashboard/pull/8825) - chore(deps): bump docker/login-action from 3.0.0 to 3.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8786](https://togithub.com/kubernetes/dashboard/pull/8786) - chore(deps-dev): bump sass from 1.71.1 to 1.72.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8789](https://togithub.com/kubernetes/dashboard/pull/8789) - chore(deps-dev): bump webpack-dev-server from 5.0.2 to 5.0.4 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8817](https://togithub.com/kubernetes/dashboard/pull/8817) - chore(deps): bump docker/setup-buildx-action from 3.1.0 to 3.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8797](https://togithub.com/kubernetes/dashboard/pull/8797) - chore(deps): bump follow-redirects from 1.15.5 to 1.15.6 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8803](https://togithub.com/kubernetes/dashboard/pull/8803) - chore(deps): bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8824](https://togithub.com/kubernetes/dashboard/pull/8824) - chore(deps-dev): bump [@​graphql-mesh/openapi](https://togithub.com/graphql-mesh/openapi) from 0.99.2 to 0.99.6 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8831](https://togithub.com/kubernetes/dashboard/pull/8831) - chore(deps): bump codecov/codecov-action from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8839](https://togithub.com/kubernetes/dashboard/pull/8839) - chore(deps-dev): bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 7.1.1 to 7.5.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8850](https://togithub.com/kubernetes/dashboard/pull/8850) - chore(deps-dev): bump minimatch from 9.0.3 to 9.0.4 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8852](https://togithub.com/kubernetes/dashboard/pull/8852) - chore(deps): bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 in /modules/api by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8727](https://togithub.com/kubernetes/dashboard/pull/8727) - chore(deps): bump azure/setup-helm from 4.0.0 to 4.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8751](https://togithub.com/kubernetes/dashboard/pull/8751) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/common/tools by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8781](https://togithub.com/kubernetes/dashboard/pull/8781) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/metrics-scraper by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8782](https://togithub.com/kubernetes/dashboard/pull/8782) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/auth by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8783](https://togithub.com/kubernetes/dashboard/pull/8783) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8785](https://togithub.com/kubernetes/dashboard/pull/8785) - chore(deps-dev): bump [@​graphql-mesh/cli](https://togithub.com/graphql-mesh/cli) from 0.89.0 to 0.89.8 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8849](https://togithub.com/kubernetes/dashboard/pull/8849) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/api by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8780](https://togithub.com/kubernetes/dashboard/pull/8780) - chore(deps): bump github.com/emicklei/go-restful/v3 from 3.11.3 to 3.12.0 in /modules/api by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8773](https://togithub.com/kubernetes/dashboard/pull/8773) - chore(deps): bump express from 4.18.3 to 4.19.2 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8845](https://togithub.com/kubernetes/dashboard/pull/8845) - chore(deps-dev): bump [@​graphql-mesh/runtime](https://togithub.com/graphql-mesh/runtime) from 0.98.0 to 0.98.7 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8847](https://togithub.com/kubernetes/dashboard/pull/8847) - chore(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.11.24 to 20.12.2 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8848](https://togithub.com/kubernetes/dashboard/pull/8848) - chore(deps): bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.2 in /modules/common/tools by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8844](https://togithub.com/kubernetes/dashboard/pull/8844) - chore(deps): bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /modules/common/client by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8784](https://togithub.com/kubernetes/dashboard/pull/8784) - chore(deps-dev): bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 7.1.0 to 7.5.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8851](https://togithub.com/kubernetes/dashboard/pull/8851) - chore(deps-dev): bump [@​babel/preset-env](https://togithub.com/babel/preset-env) from 7.24.0 to 7.24.3 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8868](https://togithub.com/kubernetes/dashboard/pull/8868) - chore(deps-dev): bump node-gyp from 10.0.1 to 10.1.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8857](https://togithub.com/kubernetes/dashboard/pull/8857) - chore(deps-dev): bump stylelint-config-standard-scss from 13.0.0 to 13.1.0 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8858](https://togithub.com/kubernetes/dashboard/pull/8858) - chore(deps): bump github.com/go-openapi/spec from 0.20.4 to 0.21.0 in /modules/api by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8862](https://togithub.com/kubernetes/dashboard/pull/8862) - chore(deps): bump ace-builds from 1.32.7 to 1.32.9 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8863](https://togithub.com/kubernetes/dashboard/pull/8863) - chore(deps-dev): bump cypress from 13.7.1 to 13.7.2 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8860](https://togithub.com/kubernetes/dashboard/pull/8860) - chore(deps-dev): bump tar from 6.2.0 to 6.2.1 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8856](https://togithub.com/kubernetes/dashboard/pull/8856) - chore(deps): bump core-js from 3.36.0 to 3.36.1 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8859](https://togithub.com/kubernetes/dashboard/pull/8859) - chore(deps-dev): bump stylelint from 16.2.1 to 16.3.1 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8861](https://togithub.com/kubernetes/dashboard/pull/8861) - chore(deps-dev): bump ng-extract-i18n-merge from 2.11.0 to 2.11.1 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8866](https://togithub.com/kubernetes/dashboard/pull/8866) - chore(deps-dev): bump [@​types/node](https://togithub.com/types/node) from 20.12.2 to 20.12.3 in /modules/web by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/kubernetes/dashboard/pull/8867](https://togithub.com/kubernetes/dashboard/pull/8867) ##### API - fix: api schema and update kong chart config by [@​floreks](https://togithub.com/floreks) in [https://github.com/kubernetes/dashboard/pull/8879](https://togithub.com/kubernetes/dashboard/pull/8879) - fix(api): role/clusterole/podlist endpoints by [@​floreks](https://togithub.com/floreks) in [https://github.com/kubernetes/dashboard/pull/8881](https://togithub.com/kubernetes/dashboard/pull/8881) ##### Helm Chart - Update csrf secret handling. It will no longer be regenerated on every helm run. Instead, it will use a lookup function to make sure that the `private.key` value is not empty. If secret will be deleted or key changed, then checksum annotation on api/auth containers will trigger a rollout restart. - Update kong `dns_order` configuration to include experimental `AAAA` record for ipv6 lookup. It can potentially fix issues with accessing Dashboard on IPv6-enabled cluster. Closes [#​8855](https://togithub.com/kubernetes/dashboard/issues/8855) - Reenable SA token automount for auth container. It is required to initialize the in-cluster go client. - Bump API image to `1.4.1` - Optimize kong deployment to minimize memory usage (down from ~250Mi to ~75Mi on start) - feat(chart): add automountServiceAccountToken to deployment specs in Helm chart by [@​jnoordsij](https://togithub.com/jnoordsij) in [https://github.com/kubernetes/dashboard/pull/8869](https://togithub.com/kubernetes/dashboard/pull/8869) - feat(chart): allow setting priorityClassName on deployments by [@​jnoordsij](https://togithub.com/jnoordsij) in [https://github.com/kubernetes/dashboard/pull/8870](https://togithub.com/kubernetes/dashboard/pull/8870) - feat(chart): bump chart version to 7.2.0 by [@​floreks](https://togithub.com/floreks) in [https://github.com/kubernetes/dashboard/pull/8882](https://togithub.com/kubernetes/dashboard/pull/8882) #### New Contributors - [@​jnoordsij](https://togithub.com/jnoordsij) made their first contribution in [https://github.com/kubernetes/dashboard/pull/8869](https://togithub.com/kubernetes/dashboard/pull/8869) **Full Changelog**: kubernetes/dashboard@kubernetes-dashboard-7.1.3...kubernetes-dashboard-7.2.0 #### Installation ```sh helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/ helm upgrade --install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard --create-namespace --namespace kubernetes-dashboard ``` #### Compatibility | Kubernetes version | 1.27 | 1.28 | 1.29 | |--------------------|-----|-----|-----| | Compatibility | ? | ? | ✓ | - `✓` Fully supported version range. - `?` Due to breaking changes between Kubernetes API versions, some features might not work correctly in the Dashboard. #### Images docker.io/kubernetesui/dashboard-api:1.4.1 docker.io/kubernetesui/dashboard-auth:1.1.2 docker.io/kubernetesui/dashboard-metrics-scraper:1.1.1 docker.io/kubernetesui/dashboard-web:1.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzkuNCIsInVwZGF0ZWRJblZlciI6IjM3LjI3OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>