moving from rc to deployment #951
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
My company ( |
|
@puja108 Could you check if you've used correct credentials (ones, that are used in your company CLA) to sign your commit? You can use |
|
@maciaszczykm Can you review and merge this? :) I'm for it |
|
I'll try to get the CLA thingy sorted out in the meanwhile. Marian had some problems there too it seems (#896) |
Current coverage is 92.49%@@ master #951 diff @@
==========================================
Files 241 241
Lines 2064 2064
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1903 1909 +6
+ Misses 161 155 -6
Partials 0 0
|
|
I changed my email to the giantswarm one, let's try again |
|
@puja108 Your commit must be signed by it :) |
As deployments (and replica sets) are replacing the rc primitive, I thought of moving this manifest to deployments, too. The `kind: list` thingy doesn't work here, as it has problems with using `extensions/v1beta1` so I used `---` to make a valid YAML list. Other than that nothing has changed. The selector had to be slightly modified to include `matchLabels:`. I've tested this already, and it works for me.
|
I had ammended the commit, but it seems the push didn't get through, this time it should have worked at least |
|
Nearly forgot, the CLA should have been solved by now. Seems like googlebot doesn't recheck. So |
|
CLAs look good, thanks! |
|
Hurrah! |
|
LGTM |
As deployments (and replica sets) are replacing the rc primitive, I thought of moving this manifest to deployments, too. The `kind: list` thingy doesn't work here, as it has problems with using `extensions/v1beta1` so I used `---` to make a valid YAML list. Other than that nothing has changed. The selector had to be slightly modified to include `matchLabels:`. I've tested this already, and it works for me.
As deployments (and replica sets) are replacing the rc primitive, I thought of moving this manifest to deployments, too.
The
kind: listthingy doesn't work here, as it has problems with usingextensions/v1beta1so I used---to make a valid YAML list.Other than that nothing has changed. The selector had to be slightly modified to include
matchLabels:.I've tested this already, and it works for me.