Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to fix build #301

Merged
merged 2 commits into from
May 17, 2019
Merged

Upgrade dependencies to fix build #301

merged 2 commits into from
May 17, 2019

Conversation

woopstar
Copy link
Member

When #300 was introduced by me, the project was unable to build because of old dependencies.

This PR will add missing dependencies dnstap/golang-dnstap and farsightsec/golang-framestream which is required by CoreDNS 1.5.0. It will also update client_golang to version 0.9.2 which CoreDNS 1.5.0 uses.

The project is now able to build locally with make build

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and prameshj May 16, 2019 06:48
@woopstar
Copy link
Member Author

/assign @prameshj

@woopstar
Copy link
Member Author

We have build the binaries and pushed a test image for linux to pasientskyhosting/k8s-dns-node-cache-amd64:1.15.2-dirty
We can confirm it works on our Kubernetes cluster where the node cache now starts and runs CoreDNS 1.5.0

@prameshj
Copy link
Contributor

Thanks for confirming this. Is Gopkg.toml file the only change made by hand?

@woopstar
Copy link
Member Author

Indeed. I only changed the toml file and added the two dependencies and upgraded the one. Nothing else was changed to make it build again.

@prameshj
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prameshj, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 97d5500 into kubernetes:master May 17, 2019
@prameshj prameshj mentioned this pull request May 30, 2019
Closed
prameshj added a commit to prameshj/dns that referenced this pull request May 30, 2019
@prameshj
Revert "Merge pull request kubernetes#301 from woopstar/upgrade-cored…
1877fc5 
…ns-fix"

This reverts commit 97d5500, reversing
changes made to 24b1708.
prameshj added a commit to prameshj/dns that referenced this pull request Apr 10, 2020
@prameshj
Revert "Merge pull request kubernetes#301 from woopstar/upgrade-cored…
708e4b6 
…ns-fix"

This reverts commit 97d5500, reversing
changes made to 24b1708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@prameshj prameshj Awaiting requested review from prameshj

Assignees

@prameshj prameshj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woopstar @prameshj @k8s-ci-robot