Skip to content

Commit

Permalink
Fill out the rest of the required sections for targeting alpha
Browse files Browse the repository at this point in the history
  • Loading branch information
ehashman committed Jan 13, 2021
1 parent 9b8235e commit 2944ab9
Showing 1 changed file with 17 additions and 4 deletions.
21 changes: 17 additions & 4 deletions keps/sig-node/2238-liveness-probe-grace-period/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,6 @@ the container terminates quickly.

### Graduation Criteria

Because this is a bugfix with a compatible API change, similar to
[KEP-1972](/keps/sig-node/1972-kubelet-exec-probe-timeouts#graduation-criteria),
it should go straight to Graduated.

<!--
**Note:** *Not required until targeted at a release.*

Expand Down Expand Up @@ -260,6 +256,11 @@ enhancement:
cluster required to make on upgrade, in order to make use of the enhancement?
-->

On upgrade: feature flag/new field will become available for use.

On downgrade: no longer available. Any workloads with the Probe
`terminationGracePeriodSeconds` set will need to unset.

### Version Skew Strategy

<!--
Expand Down Expand Up @@ -445,27 +446,37 @@ previous answers based on experience in the field._
- periodic API calls to reconcile state (e.g. periodic fetching state,
heartbeats, leader election, etc.)

No.

* **Will enabling / using this feature result in introducing new API types?**
Describe them, providing:
- API type
- Supported number of objects per cluster
- Supported number of objects per namespace (for namespace-scoped objects)

No.

* **Will enabling / using this feature result in any new calls to the cloud
provider?**

No.

* **Will enabling / using this feature result in increasing size or count of
the existing API objects?**
Describe them, providing:
- API type(s):
- Estimated increase in size: (e.g., new annotation of size 32B)
- Estimated amount of new objects: (e.g., new Object X for every existing Pod)

One new integer field on the Probe type.

* **Will enabling / using this feature result in increasing time taken by any
operations covered by [existing SLIs/SLOs]?**
Think about adding additional work or introducing new steps in between
(e.g. need to do X to start a container), etc. Please describe the details.

No, this should not affect that.

* **Will enabling / using this feature result in non-negligible increase of
resource usage (CPU, RAM, disk, IO, ...) in any components?**
Things to keep in mind include: additional in-memory state, additional
Expand All @@ -474,6 +485,8 @@ resource usage (CPU, RAM, disk, IO, ...) in any components?**
This through this both in small and large cases, again with respect to the
[supported limits].

No.

### Troubleshooting

The Troubleshooting section currently serves the `Playbook` role. We may consider
Expand Down

0 comments on commit 2944ab9

Please sign in to comment.