Skip to content

Commit

Permalink
promote ServiceNodePortStaticSubrange to stable
Browse files Browse the repository at this point in the history
  • Loading branch information
xuzhenglun committed Aug 25, 2023
1 parent eb019be commit 84b7074
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-network/3668.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
14 changes: 10 additions & 4 deletions keps/sig-network/3668-reserved-service-nodeport-range/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,9 @@ This feature doesn't modify the cluster behavior, only the order on which dynami
#### GA
- No issues reported during two releases.
- No issues reported during one release. This is because the feature is built on the top of
[ServiceIPStaticSubrange](https://kep.k8s.io/3070), which has been GA since v1.26.
Consequently, there is no need for any additional probation period.
### Upgrade / Downgrade Strategy
Expand Down Expand Up @@ -369,6 +370,10 @@ There is currently no metric available for the NodePort allocation. so 4 metric
- kube_apiserver_nodeport_allocator_allocation_total
- kube_apiserver_nodeport_allocator_allocation_errors_total
The increase of the errors metrics or the trend of the allocated_ports and available_ports doesn't change when NodePort are created or deleted.
All metrics mentioned above have been added since v1.27.
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
Since it is a purely in-memory feature the upgrade or downgrande doesn't have any impact.
Expand Down Expand Up @@ -463,9 +468,10 @@ N/A
## Implementation History
## Drawbacks
- v1.27 - Initial implementation https://github.com/kubernetes/kubernetes/pull/114418
- v1.28 - Beta
- v1.29 - GA
## Drawbacks
## Alternatives
12 changes: 8 additions & 4 deletions keps/sig-network/3668-reserved-service-nodeport-range/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ owning-sig: sig-network
participating-sigs:
status: implementable
creation-date: 2022-11-30
last-updated: 2023-05-05
last-updated: 2023-08-22
reviewers:
approvers:
- "@thockin"
Expand All @@ -16,18 +16,18 @@ see-also:
- "/keps/sig-network/3070-reserved-service-ip-range"

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: "stable"

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.28"
latest-milestone: "v1.29"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.27"
beta: "v1.28"
stable: "v1.30"
stable: "v1.29"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand All @@ -39,3 +39,7 @@ disable-supported: true

# The following PRR answers are required at beta release
metrics:
- kube_apiserver_nodeport_allocator_allocated_ports
- kube_apiserver_nodeport_allocator_available_ports
- kube_apiserver_nodeport_allocator_allocation_total
- kube_apiserver_nodeport_allocator_allocation_errors_total

0 comments on commit 84b7074

Please sign in to comment.