Skip to content

Commit

Permalink
KEP-1672: updates for v1.24
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
  • Loading branch information
andrewsykim committed Jan 21, 2022
1 parent 3998ad3 commit 9286726
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 11 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-network/1672.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
kep-number: 1672
alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
25 changes: 16 additions & 9 deletions keps/sig-network/1672-tracking-terminating-endpoints/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
## Release Signoff Checklist

- [X] Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
- [ ] KEP approvers have approved the KEP status as `implementable`
- [ ] Design details are appropriately documented
- [ ] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
- [ ] Graduation criteria is in place
- [ ] "Implementation History" section is up-to-date for milestone
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
- [X] KEP approvers have approved the KEP status as `implementable`
- [X] Design details are appropriately documented
- [X] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
- [X] Graduation criteria is in place
- [X] "Implementation History" section is up-to-date for milestone
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [X] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes

[kubernetes.io]: https://kubernetes.io/
[kubernetes/enhancements]: https://git.k8s.io/enhancements
Expand Down Expand Up @@ -164,6 +164,12 @@ E2E tests:
* `EndpointSliceTerminatingCondition` is enabled by default.
* Consensus on scalability implications resulting from additional EndpointSlice writes with approval from sig-scalability.

#### GA

* E2E tests validating that terminating pods are properly reflected in EndpointSlice API
* Additional testing / validation on the scalability/performance impact, requiring approval from sig-scalability.
* All necessary metrics are in place to provide adequate observability and monitoring for this feature.

### Upgrade / Downgrade Strategy

Since this is an addition to the EndpointSlice API, the upgrade/downgrade strategy will follow that
Expand Down Expand Up @@ -232,7 +238,8 @@ Metrics will be added for total endpoints with the `serving` and `terminating` c

###### What are the reasonable SLOs (Service Level Objectives) for the above SLIs?

N/A
N/A since the number of terminating conditions is dependant on the workload. In other words, it could be expected that a cluster
has many terminating endpoints if there were many rolling upgrades happening.

###### Are there any missing metrics that would be useful to have to improve observability of this feature?

Expand All @@ -242,7 +249,7 @@ N/A

###### Does this feature depend on any specific services running in the cluster?

N/A
None aside from the existing core Kubernetes components, specifically kube-apiserver and kube-controller-manager.

### Scalability

Expand Down
5 changes: 3 additions & 2 deletions keps/sig-network/1672-tracking-terminating-endpoints/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@ see-also:
replaces: []

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
stage: beta

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.22"
latest-milestone: "v1.24"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.20"
beta: "v1.22"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 9286726

Please sign in to comment.