Skip to content

Commit

Permalink
Add CRD conversion webhook to v1beta1 criteria to KEP
Browse files Browse the repository at this point in the history
  • Loading branch information
jpbetz committed Apr 29, 2019
1 parent 130460d commit ae54106
Showing 1 changed file with 17 additions and 3 deletions.
20 changes: 17 additions & 3 deletions keps/sig-api-machinery/20190425-crd-conversion-webhook.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@ authors:
owning-sig: sig-api-machinery
participating-sigs:
reviewers:
- "@dbsmith"
- "@lavalamp"
- "@deads2k"
- "@sttts"
- "@liggit"
- "@enisoc"
approvers:
- "@dbsmith"
- "@lavalamp"
- "@deads2k"
creation-date: 2019-04-25
last-updated: 2019-04-25
Expand Down Expand Up @@ -736,8 +735,23 @@ Consider including folks that also work outside the SIG or subproject.
## Graduation Criteria
v1beta1:
- Ensure the scenarios from (https://github.com/kubernetes/kubernetes/issues/64136) are tested:
- Ensure what is persisted in etcd matches the storage version
- Set up a CRD, persist some data, change the storage version, and ensure the previously persisted data is readable
- Ensure discovery docs track a CRD through creation, version addition, version removal, and deletion
- Ensure `spec.served` is respected
v1:
- ConversionReview API v1 is stable (including fields that need to be updated for v1beta1 or v1)
- Documented step-by-step CRD version migration workflow that covers the entire
process of migrating from one version to another (introduce a new CRD version,
add the converter, migrate clients, migrate to new storage version, all the
way to removing the old version)
## Implementation History
- Implemented in Kubernetes 1.13 release (https://github.com/kubernetes/kubernetes/pull/67006)
Expand Down

0 comments on commit ae54106

Please sign in to comment.