Skip to content

Commit

Permalink
Merge pull request #8 from cici37/crd-expression-lang-kep
Browse files Browse the repository at this point in the history
Add test plan and graduation criteria
  • Loading branch information
jpbetz authored Sep 8, 2021
2 parents 62b3c22 + 7c6dc46 commit f074d73
Showing 1 changed file with 14 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
- [Other validation support](#other-validation-support)
- [Design Details](#design-details)
- [Type Checking](#type-checking)
- [Test Plan](#test-plan)
- [Graduation Criteria](#graduation-criteria)
- [Alpha](#alpha)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Feature Enablement and Rollback](#feature-enablement-and-rollback)
- [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
Expand Down Expand Up @@ -415,6 +418,17 @@ objects and construct objects in a typesafe way. In order to construct objects
need to be able to represent the structural schema types in CEL, e.g. "v1beta1.Foo{fieldname:
value}", this is complicated by the way CEL relies on protobuf types.

### Test Plan

We will extend both the unit test suite and the integration test suite to cover the CRD validation rule described in this KEP.

### Graduation Criteria

#### Alpha

- Feature implemented behind a feature flag
- Ensure proper tests are in place.

## Production Readiness Review Questionnaire

### Feature Enablement and Rollback
Expand Down

0 comments on commit f074d73

Please sign in to comment.