Min domains in PodTopologySpread

[sanposhiho]

Enhancement Description

• One-line enhancement description (can be used as a release note): support tuning the number of domains in PodTopologySpread
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3022-min-domains-in-pod-topology-spread
• Discussion Link:
  • Tuning the number of domains in PodTopologySpread kubernetes#105291
  • ( topologySpreadConstraint doesn't work fine when only one worker node is eligible for workload kubernetes#105072 )
• Primary contact (assignee): @sanposhiho
• Responsible SIGs: scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.24
  • Beta release target (x.y): 1.25
  • Stable release target (x.y): 1.30
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3022: Min domains in PodTopologySpread #3030
  • Code (k/k) update PR(s):
    • Add MinDomains API to TopologySpreadConstraints field kubernetes#107674
    • Implement MinDomains on Pod Topology Spread kubernetes#108362
  • Docs (k/website) update PR(s):
    • Document the new MinDomainsInPodTopologySpread feature gate website#32340
• Beta
  • KEP (k/enhancements) update PR(s): [KEP-3022] Write the production readiness requirements to graduate to beta #3338
  • Code (k/k) update PR(s): Graduate MinDomains in Pod Topology Spread to beta kubernetes#110388
  • Docs (k/website) update(s): Update the doc for minDomains to graduate minDomains to beta website#35202
• Stable
  • KEP (k/enhancements) update PR(s): KEP-3022: graduate Pod Topology Spread MinDomains to stable #4407
  • Code (k/k) update PR(s): graduate MinDomainsInPodTopologySpread to stable kubernetes#123481
  • Docs (k/website) update(s): graduate MinDomain feature to stable website#45180

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sanposhiho]

/sig scheduling
/assign

[ahg-g]

/cc @x13n

[alculquicondor]

update the description to link to the merged KEP, instead of linking to the PR that added it.

[ahg-g]

/milestone v1.24

[Priyankasaggu11929]

Hello @sanposhiho 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[PI-Victor]

Hi @alculquicondor 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[Priyankasaggu11929]

Hello @alculquicondor 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Add MinDomains API to TopologySpreadConstraints field kubernetes#107674
• Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

[alculquicondor]

@sanposhiho can you work on the documentation as well?

[sanposhiho]

Sure, I will update doc and kep this weekend.

[alculquicondor]

There is no need to update the KEP.

[mehabhalodiya]

@sanposhiho I see already opened up PR: kubernetes/website/pull/32340

[sanposhiho]

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

[mehabhalodiya]

Hm, looks like other person updated the doc instead of me. Thanks for informing @mehabhalodiya.

Will you please update the issue description?
Thanks!

[sanposhiho]

@alculquicondor
Isn't the following change for kep needed? (If not needed, I'll close this)
#3245

[Priyankasaggu11929]

@sanposhiho @alculquicondor, thank you so much.

With the Docs PR kubernetes/website#32340 open now, all requirements for Code Freeze are finished. The status is now tracked.

[alculquicondor]

/milestone v1.30

[k8s-ci-robot]

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/stage stable

[alculquicondor]

/milestone v1.30

[salehsedghpour]

This enhancements is now marked as tracked

[alculquicondor]

Thank you @salehsedghpour!

[natalisucks]

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[Vyom-Yadav]

Hello @sanposhiho 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

---

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

I don't see any logical changes that might change the explanation docs. But a stability version bumping PR like kubernetes/website#35202 is required, so I'm marking this as Need Docs

[sanposhiho]

@natalisucks As we already wrote the blog when graduating to beta, we don't need a blog this time.

@Vyom-Yadav Got it, here it is: kubernetes/website#45180

[pnbrown]

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• graduate MinDomainsInPodTopologySpread to stable kubernetes#123481

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[pnbrown]

@sanposhiho, Enhancements team here!
As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented as the code PRs are merged and the feature gates are removed.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/kep.yaml

[sanposhiho]

Sure, #4543

[sanposhiho]

When should we close this issue? now, or after removing the feature gate completely?

[alculquicondor]

It's ok to close this one. Maybe leave an issue in k/k to remove the gate.

[sanposhiho]

Got it, I'll create an issue so that I don't forget.

/close

[k8s-ci-robot]

@sanposhiho: Closing this issue.

In response to this:

Got it, I'll create an issue so that I don't forget.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.