Windows node gracefully shutdown

[zylxjtu]

Enhancement Description

• One-line enhancement description (can be used as a release note): This is the suggestion to implement the [KEP2000]
• (https://github.com/zylxjtu/enhancements/tree/master/keps/sig-node/2000-graceful-node-shutdown) comparable feature on windows node
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/4802-windows-node-shutdown/README.md
• Discussion Link: This has been discussed in 8/20 sig-node meeting https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit
• Primary contact (assignee):@zylxjtu
• Responsible SIGs: sig windows node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): Add KEP 4802 - windows node shutdown #4813
  • Code (k/k) update PR(s):
    • Windows node graceful shutdown kubernetes#127404
  • Docs (k/website) update PR(s): Add windows node graceful shutdown doc website#48474

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[marosset]

/sig windows node

[pacoxu]

/stage alpha

[marosset]

/milestone v1.32

[dipesh-rawat]

Hello @zylxjtu 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

• Create the KEP readme using the latest template and merge it in the k/enhancements repo. KEP's README.md file is missing few checkboxes under the "Release Signoff Checklist" need to be added here to conform to the latest KEP template.

• Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[tuibeovince]

just a nit.
since this is an implementation of a comparable feature to GracefulNodeShutdown (https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2000-graceful-node-shutdown ) , maybe changing the order of the words in the title to reflect its relation would improve this feature's consistency, searchability, and referencing. Unless, maybe it was intentionally worded this way to make sure "windows" and "node" are directly connected.

[kannon92]

@zylxjtu

When you get a chance, can you update your descriptions with the KEP PR? Add a link to the KEP PR in the alpha section.

[SergeyKanzhelev]

/assign @zylxjtu

xref: kubernetes/kubernetes#116388

[dipesh-rawat]

Hi @zylxjtu 👋, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #4802 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

@zylxjtu With PR #4813 has been merged, almost all the KEP requirements are in place. It looks like this KEP's README.md file is missing few checkboxes under the "Release Signoff Checklist" need to be added here to confrom to the latest KEP template.

Below is the reference from the KEP template.

enhancements/keps/NNNN-kep-template/README.md

Lines 134 to 139 in c42bf65

	- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
	- [ ] e2e Tests for all Beta API Operations (endpoints)
	- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
	- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
	- [ ] (R) Graduation criteria is in place
	- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)

The current status of this enhancement is marked as at risk for enhancement freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[haircommander]

@dipesh-rawat I opened #4919

[marosset]

@dipesh-rawat - the Release Signoff Checklist has ben updated - PTAL and thanks for catching this with enough time for us to make the updates

[dipesh-rawat]

@zylxjtu @haircommander @marosset Thanks for the quick fix as part of #4919. With that merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[chanieljdan]

Hi @zylxjtu 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[rashansmith]

Hello @zylxjtu 👋 from the v1.32 Communications Team!
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

[chanieljdan]

Hi @zylxjtu 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @zylxjtu 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday October 24, 2024 18:00 PDT.

Thanks,

Daniel

[dipesh-rawat]

Hey again @zylxjtu 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Windows node graceful shutdown kubernetes#127404

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[kannon92]

Hello @zylxjtu,

Please let us know if you still have cycles to work on this for 1.32. We would need a website update as mentioned above.

I also would like to understand if kubernetes/kubernetes#116388 is an implementation of this feature. That reads like an old refactor PR and not the implementation of the KEP.

So please get back to us or we will consider this feature to no longer be tracked for release.

[zylxjtu]

I have added a draft PR for the doc in here: kubernetes/website#48474, please let me know if I am still missing anything, thanks!

The kubernetes/kubernetes#116388 is unrelated with the is feature, the corresponding code PR for this KEP is kubernetes/kubernetes#127404

[dipesh-rawat]

@zylxjtu Could you please add the code PR(s) kubernetes/kubernetes#127404 (any other related PRs in k/k also remove unrelated PRs) in the description (here), so that we can maintain accurate status.

[zylxjtu]

thanks @dipesh-rawat , updated the description part

[rashansmith]

Hello @zylxjtu 👋 from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Hello @zylxjtu , just a reminder for the feature blog deadline. To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. Please reach out if you have any questions!

[dipesh-rawat]

Hey again @zylxjtu 👋, v1.32 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in few days, at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #4802 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[dipesh-rawat]

Hello @zylxjtu 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

• Windows node graceful shutdown kubernetes#127404

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Additionally, please do let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.