Allow zero value for Sleep Action of PreStop Hook

[sreeram-venkitesh]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allows PreStop lifecycle handler's sleep action to have a zero value
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4818-allow-zero-value-for-sleep-action-of-prestop-hook/README.md
• Discussion Link: Discussion in the GitHub thread of original KEP.
  • WIP: https://docs.google.com/document/d/1o01gH2ELPY-kjwgemjg3BbWiykx37ag-4VYwwJ1jBTw/edit?usp=sharing
• Primary contact (assignee): @sreeram-venkitesh
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4818: Allow zero value for Sleep Action of PreStop Hook #4855
  • Code (k/k) update PR(s): KEP-4818: Relaxed validation for allowing zero in PreStop hook sleep action kubernetes#127094
  • Docs (k/website) update PR(s): KEP 4818: PodLifecycleSleepActionAllowZero website#48439

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sreeram-venkitesh]

/sig node

[SergeyKanzhelev]

/milestone v1.32
/label lead-opted-in

[kannon92]

Based on @SergeyKanzhelev comments, I think we can move this to be "Considered For Release".

[impact-maker]

Hello @sreeram-venkitesh 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• KEP has a production readiness review that has been merged into k/enhancements.
  The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

Thanks @impact-maker, the enhancements PR is already reviewed by the PRR team, I will resolve the comments and get it merged soon.

[sreeram-venkitesh]

@impact-maker The KEP PR #4855 has been merged!

[sreeram-venkitesh]

/stage alpha

[impact-maker]

@sreeram-venkitesh thanks! Everything looks good, I have updated the issue status to tracked for enhancements freeze

[chanieljdan]

Hi @sreeram-venkitesh 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[sreeram-venkitesh]

@chanieljdan This KEP would need docs! It needs the following (noting it down here for myself as well):

• Document the new feature gate
• Update the docs for the original Sleep Action docs to mention that people can use this feature gate to use the zero value.

I will open the PR soon! Thanks!

[chanieljdan]

@chanieljdan This KEP would need docs! It needs the following (noting it down here for myself as well):

• Document the new feature gate
• Update the docs for the original Sleep Action docs to mention that people can use this feature gate to use the zero value.

I will open the PR soon! Thanks!

Hi @sreeram-venkitesh 👋,

Thanks for your reply! Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday October 24, 2024 18:00 PDT.

Thanks,

Daniel

[sreeram-venkitesh]

@chanieljdan I've opened the placeholder PR: kubernetes/website#48439

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sreeram-venkitesh]

@wrkode This is a very small change, so I don't think this KEP would need a feature blog at this point in the release. Thanks a lot!

[wrkode]

Hi @sreeram-venkitesh, sounds good and thanks a million for the prompt feedback

[tjons]

Hello @sreeram-venkitesh 👋, Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

• KEP-4818: Relaxed validation for allowing zero in PreStop hook sleep action kubernetes#127094

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.