Introducing Sleep Action for PreStop Hook

[AxeZhan]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add Sleep Action for PreStop Hook
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/
• Discussion Link:
  • related issue
  • google doc
• Primary contact (assignee): @AxeZhan @charles-chenzz
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.29
  • Beta release target (x.y): 1.30
  • Stable release target (x.y): 1.33?
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3960: Introducing Sleep Action for PreStop Hook #3961
  • Code (k/k) update PR(s): Introducing Sleep Action for PreStop Hook kubernetes#119026
  • Docs (k/website) update PR(s):Add information about PodLifecycleSleepAction (KEP3960) website#43428
• Beta
  • KEP (k/enhancements) update PR(s): KEP-3960: promote to beta in 1.30 #4367
  • Code (k/k) update PR(s): [KEP 3960]: graduate PodLifecycleSleepAction to beta kubernetes#122456
  • Docs (k/website) update(s): graduate PodLifecycleSleepAction to beta (KEP 3960) website#45129
• Stable
  • KEP (k/enhancements) update PR(s): [KEP 3960]: Promote PodLifecycleSleepAction to stable  #4866
  • Code (k/k) update PR(s):
    • v1.32(reverted): first try: Graduate PodLifecycleSleepAction to GA kubernetes#128046 and reverted due to flake Revert "Graduate PodLifecycleSleepAction to GA" kubernetes#128627.
    • v1.33:
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[AxeZhan]

/sig node

[AxeZhan]

/cc @thockin

[SergeyKanzhelev]

/milestone v1.28

adding to the milestone for tracking

[Atharva-Shinde]

Hello @AxeZhan 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Add approver/s to prod-readiness yaml file
• Change the status of the KEP to implementable
• Get approval from the PRR authors

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

/stage alpha

[Atharva-Shinde]

Hey @AxeZhan,
We would just need to update the status inside kep.yaml to implementable instead of provisional as mentioned in my comment above. Please make the change within 24 hours else you would have to file an exception request.
Thanks :)

[SergeyKanzhelev]

this should be updated now. Since there were no material change, can we get it tracked for 1.28?

[Atharva-Shinde]

With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[AdminTurnedDevOps]

Hey @AxeZhan

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[charles-chenzz]

hi @AdminTurnedDevOps , we currently working on the implement in k/k repos, when we finish it, we will start to add docs. Thanks.

[AxeZhan]

Hey @AdminTurnedDevOps
Thank you for your remind!

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

This definitely needs some new docs :)
I've created a draft pr for place holder, and have updated the link in the Description above, we'll get back to finish the detail after the code changes are done.
We are not very familiar with updating the documentation, so we may need some assistance from your team when the time comes. Thank you in advance!

[kannon92]

Checking in @AxeZhan. Do you want to take this to stable in 1.32?

[AxeZhan]

Checking in @AxeZhan. Do you want to take this to stable in 1.32?

Yes. I think it should be ok to take this to stable in 1.32. We have waited for 2 releases, and haven't seen some bug reports.

A few days ago, @googs1025 approached me offline, expressing interest in participating in the GA work. @googs1025 If this is still your intention, please go ahead. Otherwise, I can take over in a few days.

[googs1025]

Checking in @AxeZhan. Do you want to take this to stable in 1.32?

Yes. I think it should be ok to take this to stable in 1.32. We have waited for 2 releases, and haven't seen some bug reports.

A few days ago, @googs1025 approached me offline, expressing interest in participating in the GA work. @googs1025 If this is still your intention, please go ahead. Otherwise, I can take over in a few days.

@AxeZhan
Sorry for the late reply, you can take it directly, I am busy with other things. Thanks for the reminder!

[dipesh-rawat]

Hello @AxeZhan 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• Update kep.yaml to mention latest-milestone: v1.32.
• Complete the PRR review process for stable stage and merge it into k/enhancements.

It looks like #4866 will address most of these issues.

• Get [KEP 3960]: Promote PodLifecycleSleepAction to stable  #4866 merged before the enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @AxeZhan 👋, v1.32 Enhancements team here,

Now that PR #4866 has been merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[michellengnx]

Hello @SergeyKanzhelev, @bobbypage, @mrunalp and @thockin 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[mbianchidev]

Hello everyone @SergeyKanzhelev @bobbypage @mrunalp @thockin👋 from the v1.32 Communications Team!

We'd love for you to consider writing a feature blog about your enhancement.
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and it is graduating.

To opt-in, let us know by opening a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we finalize the blog schedule.

[dipesh-rawat]

Hey again @AxeZhan 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Graduate PodLifecycleSleepAction to GA kubernetes#128046

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[michellengnx]

Hello @SergeyKanzhelev, @bobbypage, @mrunalp and @thockin 👋, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @SergeyKanzhelev, @bobbypage and @mrunalp 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

Thanks,
Michelle

[AxeZhan]

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

@michellengnx Does kubernetes/website#48295 work?

[dipesh-rawat]

Hello @AxeZhan 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

• Graduate PodLifecycleSleepAction to GA kubernetes#128046

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Additionally, please do let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

[AxeZhan]

/remove-milestone v1.32

[dipesh-rawat]

Looks like the code was reverted as part of kubernetes/kubernetes#128627 due to test flakes and the KEP is no longer targeting stable for v1.32 release. Marking this as Removed for v1.32 release cycle now.

/label tracked/no
/remove-label tracked/yes
/milestone clear

[sreeram-venkitesh]

@AlexanderYastrebov @szuecs Wanted to ping you folks regarding the earlier conversation about zero sleep duration. Allowing zero sleep duration is in alpha in v1.32 with #4818. You can use the PodLifecycleSleepActionAllowZero feature gate to enable zero as a valid duration for the sleep action. Please let me know if you have any feedback on this!