Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate PodLifecycleSleepAction to beta (KEP 3960) #45129

Merged
merged 1 commit into from
Mar 23, 2024
Merged

graduate PodLifecycleSleepAction to beta (KEP 3960) #45129

merged 1 commit into from
Mar 23, 2024

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Feb 14, 2024

This should only involves the stage change of the feature gate.

/hold
Wait for kubernetes/kubernetes#122456

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 14, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7151fc2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65cd6d0f0f87ff0008c287f0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2024
@AxeZhan AxeZhan mentioned this pull request Feb 14, 2024
Open
12 tasks
@sftim
Copy link
Contributor

sftim commented Feb 14, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 14, 2024
sftim
sftim reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Please also revise https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-implementations (the feature gate is now enabled by default).

@AxeZhan
Copy link
Member Author

AxeZhan commented Feb 14, 2024

Hi. Please also revise https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-implementations

Hmmm, copied from #hook-handler-implementations 

The "Sleep" action is available when the [feature gate](https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/) PodLifecycleSleepAction is enabled.

Do we need to mention the feature gate is enabled default now? As user can see the default value of a feature gate when they click the feature gate link.

@sftim
Copy link
Contributor

sftim commented Feb 14, 2024

Do we need to mention the feature gate is enabled default now? As user can see the default value of a feature gate when they click the feature gate link.

Yes, please reword to imply that it's an opt out.

sftim
sftim reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@reylejano
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Feb 16, 2024
@AxeZhan
Copy link
Member Author

AxeZhan commented Feb 20, 2024

/hold cancel
As kubernetes/kubernetes#122456 has been merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@Princesso
Copy link
Contributor

Hello @AxeZhan 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@katcosgrove
Copy link
Contributor

Hey @AxeZhan! Just a reminder that this needs to be reviewed and ready to merge by Docs Freeze on March 26, including a technical review. An exception request will be required if you cannot meet that deadline. Thank you!

cc: @bobbypage @mrunalp @thockin @SergeyKanzhelev

@AxeZhan
Copy link
Member Author

AxeZhan commented Mar 15, 2024

/cc @thockin @kannon92
Can you guys give a review from sig-node side first?

kannon92
kannon92 reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3e11d00d3bd589f021437c6b227c7bcbe62e84a

@kannon92
Copy link
Contributor

/assign @sftim @nate-double-u

@Princesso
Copy link
Contributor

Hello @AxeZhan 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@Princesso
Copy link
Contributor

Could you ple look at this one more time?
/assign @sftim @nate-double-u

dipesh-rawat
dipesh-rawat reviewed Mar 23, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 16a3008 into kubernetes:dev-1.30 Mar 23, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@kannon92 kannon92 kannon92 left review comments

@bradtopol bradtopol Awaiting requested review from bradtopol

@windsonsea windsonsea Awaiting requested review from windsonsea

@thockin thockin Awaiting requested review from thockin

Assignees

@kannon92 kannon92

@nate-double-u nate-double-u

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
10 participants
@AxeZhan @sftim @reylejano @Princesso @katcosgrove @k8s-ci-robot @kannon92 @drewhagen @dipesh-rawat @nate-double-u