Support configurable pod resolv.conf #504

MrHohn · 2017-10-27T22:45:50Z

Feature Description

One-line feature description (can be used as a release note): Support configurable pod resolv.conf.
Primary contact (assignee): @MrHohn
Responsible SIGs: sig-network
Design proposal link (community repo): Add proposal for configurable pod resolv.conf community#1276
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bowei
Approver (likely from SIG/area to which feature belongs): @thockin
Feature target (which target equals to which milestone):
- Alpha release target (1.9)
- Beta release target (1.10)
- Stable release target (1.14)

MrHohn · 2017-10-27T22:45:58Z

/sig network

MrHohn · 2017-10-27T22:47:57Z

/assign

@bowei

Automatic merge from submit-queue (batch tested with PRs 55657, 54758, 47584, 55758, 55651). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move DNS related kubelet codes into its own package **What this PR does / why we need it**: Ref kubernetes/enhancements#504, this PR rearranges DNS related kubelet codes into its own pacakge and adds an OWNERS file. Again, there is no functional changes, just that codes are moved around and couple fields (`clusterDomain`, `clusterDNS`, `resolverConfig`) are replaced with a `dnsConfigurer` struct. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /assign @bowei @thockin **Release note**: ```release-note NONE ```

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ```

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@bowei

Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add Custom Pod DNS to Kubernetes API **What this PR does / why we need it**: Ref: - Feature issue: kubernetes/enhancements#504 - Proposal: kubernetes/community#1276 This PR adds the relevant APIs, validation check and the underlying kubelet changes. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #NONE **Special notes for your reviewer**: /sig network @kubernetes/sig-network-api-reviews /assign @bowei @thockin **Release note**: ```release-note Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha). ``` Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

idvoretskyi · 2018-01-29T17:06:14Z

@MrHohn the feature is still labeled as alpha, but your plans for 1.10 were beta. What is the actual status of the feature for 1.10?

MrHohn · 2018-01-29T17:50:20Z

@idvoretskyi Thanks for checking in. This feature is targeting beta for 1.10.

/stage beta

MrHohn · 2018-01-29T17:51:36Z

Seems like I don't have the label privilege though. @idvoretskyi Would be great to use your help :)

MrHohn · 2019-01-23T22:57:28Z

@claurence Thanks for handling the milestone and labels. To confirm, we need to merge the KEP PR (#700) before the Enhancements freeze, right?

claurence · 2019-01-24T14:54:16Z

@MrHohn we'd like the KEP in an implementable state by enhancements freeze.

claurence · 2019-02-11T17:06:33Z

@MrHohn Hello - enhancements lead here - looking at the KEP it is still marked as "provisional". What more is needed for it to move to "implementable"

Additionally are there any open PRs that should be tracked for this issue for the 1.14 release?

MrHohn · 2019-02-11T17:50:51Z

@claurence Thanks for checking in. The KEP should be implementable --- I will update that.

One more open PR is kubernetes/website#12514 for the doc change.

liggitt · 2019-02-15T04:59:16Z

kubernetes/kubernetes#72832 merged, no visible API changes

claurence · 2019-02-22T21:27:22Z

@MrHohn looking over the KEP I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

MrHohn · 2019-02-22T21:34:30Z

@claurence We have comprehensive e2e tests implemented a while back, and that task was tracked by kubernetes/kubernetes#56521. I can retrospectively add testing plans to the KEP if that is preferable.

claurence · 2019-02-22T21:40:37Z

@MrHohn if you can add them to the KEP that would be great!

lledru · 2019-02-25T15:14:30Z

Hello @MrHohn , 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

MrHohn · 2019-02-26T01:26:15Z

@lledru Thanks for checking in. There is no open K/K PRs that need to merge. (I do need to send a PR to add testing plans to KEP but that is not K/K.)

lledru · 2019-03-03T19:52:00Z

Hi @MrHohn, when do you think you could merge PR #867 ? Just checked with my enhancement teammates, this information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.
If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release. Best regards

MrHohn · 2019-03-03T19:58:38Z

@lledru We will make sure to get that in before 1.14 code freeze (hopefully next Monday-ish).

spiffxp · 2019-03-19T05:41:20Z

/remove-stage beta
/stage stable

MrHohn · 2019-04-04T18:20:22Z

Closing this as it is GA with 1.14.

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Oct 27, 2017

k8s-ci-robot assigned MrHohn Oct 27, 2017

idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Nov 13, 2017

idvoretskyi added this to the v1.9 milestone Nov 13, 2017

This was referenced Nov 14, 2017

Move DNS related kubelet codes into its own package kubernetes/kubernetes#55651

Merged

Add Custom Pod DNS to Kubernetes API kubernetes/kubernetes#55848

Merged

This was referenced Nov 17, 2017

Support Custom Pod DNS in kubelet kubernetes/kubernetes#55966

Closed

[WIP] Documentation for custom pod DNS alpha feature kubernetes/website#6408

Closed

MrHohn mentioned this issue Nov 29, 2017

Need e2e test for configurable pod resolv.conf (a.k.a CustomPodDNS) kubernetes/kubernetes#56521

Closed

freehan modified the milestones: v1.9, v1.10 Jan 22, 2018

idvoretskyi added kind/feature Categorizes issue or PR as related to a new feature. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 29, 2018

idvoretskyi added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 29, 2018

claurence removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 22, 2019

liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 31, 2019

MrHohn mentioned this issue Feb 5, 2019

Minor doc change for GAing Pod DNS Config kubernetes/website#12514

Merged

MrHohn mentioned this issue Feb 11, 2019

Update pod DNS config KEP to implementable #823

Merged

liggitt removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 15, 2019

MrHohn mentioned this issue Mar 2, 2019

Add test plan to pod DNS config KEP #867

Merged

k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 19, 2019

MrHohn closed this as completed Apr 4, 2019

kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019

This was referenced Sep 13, 2022

kubelet: append options to pod if there are multi options in /etc/resolv.conf kubernetes/kubernetes#112414

Merged

kubelet doesn't merge multiple 'options' lines from node /etc/resolv.conf kubernetes/kubernetes#112323

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support configurable pod resolv.conf #504

Support configurable pod resolv.conf #504

MrHohn commented Oct 27, 2017 •

edited

Loading

MrHohn commented Oct 27, 2017

MrHohn commented Oct 27, 2017

idvoretskyi commented Jan 29, 2018

MrHohn commented Jan 29, 2018

MrHohn commented Jan 29, 2018

MrHohn commented Jan 23, 2019

claurence commented Jan 24, 2019

claurence commented Feb 11, 2019

MrHohn commented Feb 11, 2019

liggitt commented Feb 15, 2019

claurence commented Feb 22, 2019

MrHohn commented Feb 22, 2019

claurence commented Feb 22, 2019

lledru commented Feb 25, 2019

MrHohn commented Feb 26, 2019

lledru commented Mar 3, 2019

MrHohn commented Mar 3, 2019

spiffxp commented Mar 19, 2019

MrHohn commented Apr 4, 2019

Support configurable pod resolv.conf #504

Support configurable pod resolv.conf #504

Comments

MrHohn commented Oct 27, 2017 • edited Loading

Feature Description

MrHohn commented Oct 27, 2017

MrHohn commented Oct 27, 2017

idvoretskyi commented Jan 29, 2018

MrHohn commented Jan 29, 2018

MrHohn commented Jan 29, 2018

MrHohn commented Jan 23, 2019

claurence commented Jan 24, 2019

claurence commented Feb 11, 2019

MrHohn commented Feb 11, 2019

liggitt commented Feb 15, 2019

claurence commented Feb 22, 2019

MrHohn commented Feb 22, 2019

claurence commented Feb 22, 2019

lledru commented Feb 25, 2019

MrHohn commented Feb 26, 2019

lledru commented Mar 3, 2019

MrHohn commented Mar 3, 2019

spiffxp commented Mar 19, 2019

MrHohn commented Apr 4, 2019

MrHohn commented Oct 27, 2017 •

edited

Loading