Kubernetes CSI topology support

[verult]

Feature Description

• One-line feature description (can be used as a release note): Kubernetes CSI topology support
• Primary contact (assignee): @verult @vladimirvivien
• Responsible SIGs: sig-storage
• Design proposal link (community repo): Topology updates to Kubernetes CSI implementation community#2034
• Link to e2e and/or unit tests:
• Reviewer(s): @msau42 @saad-ali
• Approver (likely from SIG/area to which feature belongs): @saad-ali
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y) 1.12
  • Beta release target (x.y) 1.14
  • Stable release target (x.y) 1.16

[justaugustus]

/assign @verult @vladimirvivien

[justaugustus]

@mikedanese -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

[saad-ali]

This feature did not make it in to 1.11, punting to 1.12.

@verult Please link to design doc

[justaugustus]

Thanks for the update, @saad-ali!!

[warmchang]

Both alpha and beta milestone are the 1.12?

[verult]

@warmchang updated, thanks!

[warmchang]

welcome!

…

________________________________ 发件人: Cheng Xing <notifications@github.com> 发送时间: 2018年6月30日 8:41 收件人: kubernetes/features 抄送: William Zhang; Mention 主题: Re: [kubernetes/features] Kubernetes CSI topology support (#557) @warmchang<https://github.com/warmchang> updated, thanks! ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#557 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMen0DazzioXL7fRzAfMO_JFueEpZRYPks5uBslEgaJpZM4TSmdV>.

[justaugustus]

@verult @vladimirvivien @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

[verult]

@justaugustus yes so far it has mostly been design work, but I've just begun prototyping. Some design aspects might take time to decide but still aiming for 1.12 at this time.

[justaugustus]

@verult thanks for the update! We've added it to the tracking sheet.

[vladimirvivien]

@verult is there a PR yet for this ?

[verult]

@vladimirvivien no code PR yet, the design doc PR linked in the description is WIP at the moment as several aspects are under discussion, including CSI registry, label format, and the possibility of leveraging a new TopologyDomains object (part of the capacity reporting proposal).

[zparnold]

Hey there! @verult I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[msau42]

I will be adding some documentation here: kubernetes/website#9939. We'll need to see what other additional documentation will be needed for the CSI integration.

[justaugustus]

@verult @vladimirvivien --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[msau42]

The PR did not make 1.12 code freeze and we've requested an exception

[justaugustus]

Got it. Thanks for the update!

[mariantalla]

Hey @vladimirvivien @verult @thockin @msau42 - I'm an enhancements shadow for 1.16. Are there plans for this feature to graduate alpha/beta/stable stages? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed there was no KEP linked in the issue description; as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

As a reminder; 1.16 milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

[msau42]

This is remaining beta in 1.16

[kcmartin]

Hello @msau42, 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

• PR is merged in
• In an implementable state
• Include test plan and graduation criteria
• All relevant k/k PRs should be listed in this issue

Thank you.

[msau42]

HI @kcmartin, we intend to graduate this feature to GA in 1.17. I will be starting on the KEP update shortly.

[msau42]

KEP update: #1273

[kcmartin]

/milestone v1.17

[msau42]

/assign

[msau42]

API + feature gate PR: kubernetes/kubernetes#83474
Other misc CSI sidecar work tracked in: https://github.com/orgs/kubernetes-csi/projects/19

[kcmartin]

Hi @msau42 -- We're only 5 days away from the Enhancements Freeze (Tuesday, October 15, EOD PST). Another friendly reminder that to be able to graduate this in the 1.17 release, KEP must have graduation criteria defined, in an implementable state, and merged in.

[irvifa]

Hello @msau42 I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

@msau42

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

[msau42]

Docs PR: kubernetes/website#17408

[kcmartin]

Hi @msau42
I am one of the Enhancements Shadows for the 1.17 Release Team. We are very near to Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that  kubernetes/kubernetes#83474 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

[msau42]

All the work to make the feature GA in 1.17 is done.
/close

[k8s-ci-robot]

@msau42: Closing this issue.

In response to this:

All the work to make the feature GA in 1.17 is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

Hi @msau42, since this enhancement graduated in 1.17, can you please mark the KEP as implemented? 🙂

[palnabarun]

/reopen

(reopening this issue in the interim)

[k8s-ci-robot]

@palnabarun: Reopened this issue.

In response to this:

/reopen

(reopening this issue in the interim)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.