Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline and persistent volumes #1129

Merged
merged 2 commits into from
Jul 16, 2019
Merged

inline and persistent volumes #1129

merged 2 commits into from
Jul 16, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jul 8, 2019

Defines how to support persistent and inline volumes in the same driver installation and cleans up some language.

Related-to: kubernetes/kubernetes#79624

pohly added 2 commits July 8, 2019 09:40
@pohly
CSI inline volumes: fix PodSecurity comment
a0465b4 
Comment and plain text were inconsistent regarding the default
behavior.
@pohly
CSI inline volumes: support both modes in the same driver
a84afe4 
Some drivers might manage local resources that can be accessed both
via PVC and inline. This extends the KEP to support that.

Some other parts also get updated to clarify what drivers are passed
at which point.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from childsb and saad-ali July 8, 2019 07:53
@pohly
Copy link
Contributor Author

pohly commented Jul 8, 2019

/cc @vladimirvivien @kfox1111

@k8s-ci-robot
Copy link
Contributor

@pohly: GitHub didn't allow me to request PR reviews from the following users: kfox1111.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @vladimirvivien @kfox1111

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pohly pohly mentioned this pull request Jul 8, 2019
Closed
@kfox1111
Copy link

kfox1111 commented Jul 8, 2019

This looks good to me.

@pohly
Copy link
Contributor Author

pohly commented Jul 16, 2019

/assign @childsb

@childsb
Copy link
Contributor

childsb commented Jul 16, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 79119ce into kubernetes:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childsb childsb Awaiting requested review from childsb

@saad-ali saad-ali Awaiting requested review from saad-ali

@vladimirvivien vladimirvivien Awaiting requested review from vladimirvivien

Assignees

@childsb childsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pohly @k8s-ci-robot @kfox1111 @childsb