Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PVC DataSource to GA #1515

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Update PVC DataSource to GA #1515

merged 1 commit into from
Jan 28, 2020

Conversation

j-griffith
Copy link
Contributor

Update KEP to note graduation from Beta to GA for sig-storage cloning
feature in 1.18. Also add testing section to KEP.

issue: #989

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2020
@j-griffith
Copy link
Contributor Author

/assign @msau42

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 27, 2020
msau42
msau42 reviewed Jan 27, 2020
View reviewed changes
keps/sig-storage/20181111-extend-datasource-field.md

### E2E tests

Require addition of E2E tests using the clone feature of the CSI host provisioner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add some more specific test cases we want to add? Like integration with other volume features like Raw Block, concurrent cloning operations on the same volume, stress/failure tests, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloning while the source is being deleted

@j-griffith j-griffith force-pushed the cloning_to_ga branch 2 times, most recently from 0bef14a to ef01145 Compare January 28, 2020 01:06
msau42
msau42 reviewed Jan 28, 2020
View reviewed changes
keps/sig-storage/20181111-extend-datasource-field.md Outdated
@@ -134,6 +155,8 @@ Given that the only implementation changes in Kuberenetes is to enable the featu
## Implementation History

1.15 - Alpha status
1.16 - Beta status
1.18 - GA Status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would either remove the 1.18 - GA since it's not official yet, or add a note that we're targeting GA in 1.18

@j-griffith
Update PVC DataSource to GA
306ce54 
Update KEP to note graduation from Beta to GA for sig-storage cloning
feature in 1.18. Also add testing section to KEP.

issue: kubernetes#989
@msau42
Copy link
Member

msau42 commented Jan 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2020
saad-ali
saad-ali approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-griffith, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit e485562 into kubernetes:master Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali saad-ali approved these changes

@childsb childsb Awaiting requested review from childsb

Assignees

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@j-griffith @msau42 @k8s-ci-robot @saad-ali