Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 1.18 storage GA features as implemented #1605

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Mar 9, 2020

Marking couple of KEPs that reached GA in this release:

/assign @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Mar 9, 2020
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the implementation history sections at the bottom too?

@johnbelamaric
Copy link
Member

ping - can we get this finished up and merged?

@palnabarun
Copy link
Member

@jsafrane Ping. Any updates on this? 🙂

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@jsafrane
Copy link
Member Author

I totally missed this PR.

I added history to KEPs where it was missing and tailoring it on places where it was "targeting GA".

@msau42
Copy link
Member

msau42 commented Apr 14, 2020

lgtm
TOC needs to be updated

@jsafrane
Copy link
Member Author

TOC updated

@msau42
Copy link
Member

msau42 commented Apr 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c2efdfe into kubernetes:master Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 15, 2020
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this pull request Jul 30, 2024
Dynamically set Imagestream importMode based on cluster payload type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants