Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kustomize components KEP #1803

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Add Kustomize components KEP #1803

merged 3 commits into from
Jun 17, 2020

Conversation

apyrgio
Copy link
Contributor

@apyrgio apyrgio commented May 20, 2020

This enhancement proposal introduces components, a new kind of
Kustomization that allows users to define reusable kustomizations.

Main discussion: kubernetes-sigs/kustomize#1251
User story that spawned this KEP: kubernetes-sigs/kustomize#2438

@apyrgio
Add Kustomize components KEP
35e9662 
This enhancement proposal introduces components, a new kind of
Kustomization that allows users to define reusable kustomizations.

Main discussion: kubernetes-sigs/kustomize#1251
User story that spawned this KEP: kubernetes-sigs/kustomize#2438
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @apyrgio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from pwittrock and seans3 May 20, 2020 12:22
@apyrgio
Copy link
Contributor Author

apyrgio commented May 20, 2020

/cc @ioandr @pgpx

@k8s-ci-robot
Copy link
Contributor

@apyrgio: GitHub didn't allow me to request PR reviews from the following users: ioandr, pgpx.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ioandr @pgpx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 20, 2020
Merged
Closed
@apyrgio
Copy link
Contributor Author

apyrgio commented May 20, 2020

/assign @soltysh

@apyrgio apyrgio mentioned this pull request May 20, 2020
Closed
@pwittrock
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2020
@pwittrock
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@pwittrock
Copy link
Member

Hold for lazy consensus until the next sig-cli meeting

@pwittrock
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apyrgio, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@pwittrock
Copy link
Member

@apyrgio plz check the failure

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@apyrgio
Copy link
Contributor Author

apyrgio commented May 22, 2020

/test pull-enhancements-verify

@apyrgio
Copy link
Contributor Author

apyrgio commented May 22, 2020

/retest

@apyrgio
Copy link
Contributor Author

apyrgio commented May 22, 2020

The checks now pass. I've pushed a commit that fixes them, you can squash it during merge.

@dan-slinky-ckpd dan-slinky-ckpd mentioned this pull request May 26, 2020
Closed
@zishan zishan mentioned this pull request May 28, 2020
Closed
@bittner
Copy link

bittner commented Jun 6, 2020

Who can add a lgtm label, so that this PR can be merged?

stellirin
stellirin reviewed Jun 7, 2020
View reviewed changes
keps/sig-cli/1802-kustomize-components.md Outdated
In order to use a component, the user can refer to it in their
`kustomization.yaml` via the `components` field:

```yaml:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```yaml:
```yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@apyrgio
Minor fixes for Kustomize components KEP
6f85d03 
Fix some issues that were detect by the CI tests.
@apyrgio
Copy link
Contributor Author

apyrgio commented Jun 15, 2020

FYI, I've added for posterity the rationale on introducing the components: field and the Component kind. Please give it a look as well. Also, now that the corresponding PR on Kustomize is merged, I think that this KEP can be merged as well.

@monopole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@pwittrock
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit bf3bd6c into kubernetes:master Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellirin stellirin stellirin left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

@monopole monopole

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@apyrgio @k8s-ci-robot @pwittrock @bittner @monopole @stellirin @soltysh