-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1815: Add ComponentConfig ObjectMeta KEP #1816
Conversation
phenixblue
commented
May 27, 2020
- Cleanup some things in README
- Update title
- Update KEP with issue number
/assign |
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/kep.yaml
Outdated
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/kep.yaml
Outdated
Show resolved
Hide resolved
/wg component-standard |
2dcc017
to
0693192
Compare
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Outdated
Show resolved
Hide resolved
0693192
to
330356f
Compare
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Show resolved
Hide resolved
keps/sig-cluster-lifecycle/wgs/1815-componentconfig-objectmeta/README.md
Outdated
Show resolved
Hide resolved
Cleanup some things in README Update title Update KEP with issue number
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi all, This PR has been open for 2.5 years. Will this KEP move forward or should it be closed and revisited? Thanks! |
The working group has been disbanded so I'm not sure what it would take to move this forward. If someone else wants to try and push it forward I can help provide context. Otherwise I think it can be closed. |
I am still interested in seeing this go in. And from what I can understand, this does not require much of a code change, nor does it have much risk. I am not familiar with the KEP process or whar it would take to get this in, but happy to help out any way I can. |
fwiw, in kubeadm's latest cc we decided to not add this. the only known use case was kustomize patching of cc files pre-passing them with --config to kubeadm, which is possible with manual edits to add "name". the embedded objectmeta also conflicted with a kubeadm clusterconfiguration "name". the stock objectmeta has a lot of fields and the use cases for them are still not very clear to me. it would make some sense if we treat a cc object as a k8s object managed by controller. |
The kOps use case is a bit narrow, but kops cli has a few command similar to As far as I know, for CC, it is only labels that we would be interested in. Possibly annotations as well (e.g to say ignore various validations or mutations kOps would do to ensure a working configuration). |
understood. potentialy a topic for the sig mailing list /zoom call if you wish to open the discussion. |
I may have been too hastly. I can see we'd like to have |
name, labels, annotations are the known use cases to me. |
Yeah, the intent was to closely mirror what was done in cluster-api |
Namespace can definitely be skipped, and we I don't see that having both labels and annotations would serve any purpose. Since selectors doesn't make that much sense for this, I'd be happy to have only annotations and name be in scope for now. I am also happy to do a separate smaller object as suggested in the KEP. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |