Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark SIG Instrumentation metrics overhaul KEP as implemented #1935

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Mark SIG Instrumentation metrics overhaul KEP as implemented #1935

merged 1 commit into from
Aug 13, 2020

Conversation

ehashman
Copy link
Member

Closes #1206.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2020
@ehashman
Copy link
Member Author

/cc @brancz

ehashman
ehashman commented Aug 12, 2020
View reviewed changes
keps/sig-instrumentation/20181106-kubernetes-metrics-overhaul.md
## Graduation Criteria

All metrics exposed by components from kubernetes/kubernetes follow Prometheus best practices and (nice to have) tooling is built and enabled in CI to prevent simple violations of said best practices.

## Implementation History

Multiple pull requests have already been opened, but not merged as of writing of this document.
As of release 1.17, this KEP is considered fully implemented.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me like an hour to dig up all these PRs and update the KEP so I hope this will be appreciated 😁

@brancz
Copy link
Member

brancz commented Aug 13, 2020

🎉 🥳

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4bcce78 into kubernetes:master Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 13, 2020
@ehashman ehashman deleted the metrics-overhaul branch August 13, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole Awaiting requested review from dashpole

@logicalhan logicalhan Awaiting requested review from logicalhan

@brancz brancz Awaiting requested review from brancz

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Kubernetes Metrics Overhaul
3 participants
@ehashman @k8s-ci-robot @brancz