-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-cli: Use XDG Base Directory Specification #2111
sig-cli: Use XDG Base Directory Specification #2111
Conversation
Welcome @dougsland! |
Hi @dougsland. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- you must open an issue to track the kep kubernetes/enhancements/issues
- you are using an old kep format, please update to use the current required format found here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template
e047d78
to
8e52497
Compare
8e52497
to
f63ac1e
Compare
|
802f3a2
to
bdf8169
Compare
keps/sig-cli/2229-kubectl-xdg-base-dir/20201022-kubectl-xdg-base-dir.md
Outdated
Show resolved
Hide resolved
31212f8
to
c2e8aa1
Compare
c2e8aa1
to
dd7c364
Compare
dd7c364
to
90bcea3
Compare
Thank you for helping me finding the context. 👌 Too bad about this feature. I hope you all reconsider later, or that a more modern alternative of this tool replaces it in the future. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
owning-sig: sig-cli | ||
participating-sigs: | ||
- sig-usability | ||
status: implementable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougsland this should be rejected
as we agreed.
- "@soltysh" | ||
|
||
# The target maturity stage in the current dev cycle for this KEP. | ||
stage: beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave stage and milestones empty, not to confuse folks.
be6778c
to
0de9fa8
Compare
This KEP aim to provide all requirements for kubectl use XDG Base Directory Specification. Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
0de9fa8
to
80066d4
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This KEP aim to provide all requirements for kubectl use XDG Base Directory Specification.
Issue: #2229
PR: kubernetes/kubernetes#97885
Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com