Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-cli: Use XDG Base Directory Specification #2111

Merged

Conversation

dougsland
Copy link
Member

@dougsland dougsland commented Oct 22, 2020

This KEP aim to provide all requirements for kubectl use XDG Base Directory Specification.

Issue: #2229
PR: kubernetes/kubernetes#97885

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @dougsland!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @dougsland. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Oct 22, 2020
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. you must open an issue to track the kep kubernetes/enhancements/issues
  2. you are using an old kep format, please update to use the current required format found here: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from e047d78 to 8e52497 Compare January 3, 2021 02:24
@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from 8e52497 to f63ac1e Compare January 3, 2021 12:59
@dougsland
Copy link
Member Author

Two things:

  1. you must open an issue to track the kep kubernetes/enhancements/issues
  2. you are using an old kep format, please update to use the current required format found here:
    https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

#2229

@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch 2 times, most recently from 802f3a2 to bdf8169 Compare January 7, 2021 03:39
@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch 2 times, most recently from 31212f8 to c2e8aa1 Compare January 9, 2021 20:18
@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from c2e8aa1 to dd7c364 Compare January 10, 2021 01:37
@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from dd7c364 to 90bcea3 Compare January 10, 2021 02:15
@Mange
Copy link

Mange commented May 20, 2021

Thank you for helping me finding the context. 👌


Too bad about this feature. I hope you all reconsider later, or that a more modern alternative of this tool replaces it in the future.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2021
owning-sig: sig-cli
participating-sigs:
- sig-usability
status: implementable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougsland this should be rejected as we agreed.

- "@soltysh"

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave stage and milestones empty, not to confuse folks.

@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from be6778c to 0de9fa8 Compare September 9, 2021 15:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2021
This KEP aim to provide all requirements for kubectl
use XDG Base Directory Specification.

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland dougsland force-pushed the kubectl-xdg-base-dir-sig-cli branch from 0de9fa8 to 80066d4 Compare September 9, 2021 15:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2021
@soltysh
Copy link
Contributor

soltysh commented Sep 9, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2021
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.