Remove the restriction on empty namespaceSelector in podaffinity #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
lgtm |
|
lgtm - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2249
We initially proposed to disallow empty namespaceSelector. Users however can select all namespaces as follows:
Selecting all namespaces will likely be a common usage pattern, which we can easily special case and optimize in the scheduler implementation (by avoiding listing namespaces and matching against their labels since all namespaces are eligible). And so I am suggesting we drop the restriction on empty namespaceSelector to avoid forcing users to opt into the pattern above which requires more processing.
@wojtek-t @liggitt @Huang-Wei @alculquicondor