Make some cleanup in KEP PRR template and building scripts

[rikatz]

This PR:

• Cleans the verify-build.sh to build only for amd64 (as we run the tests in amd64 only, right?) cutting a bit the tests time
• Make some statement about creating the PRR file on the right place, removing it from kep.yaml

[rikatz]

Maybe we can keep darwin and windows/amd64, but I'm really wondering if we need the others.

[ehashman]

I noticed the same thing today, 👍

[rikatz]

yep! So for example, currently only with linux/amd64:

time ./hack/verify-build.sh 
Building project for linux/amd64

real    0m6,042s
user    0m16,617s
sys     0m2,836s

While adding windows and darwin:

time ./hack/verify-build.sh 
Building project for linux/amd64
Building project for windows/amd64
Building project for darwin/amd64

real    0m20,079s
user    1m28,200s
sys     0m8,459s

And so goes this. So I can say this PR improves the KEP CI performance by 900% :P

[palnabarun]

Let's keep darwin/amd64, linux/amd64 and possibly linux/arm64. (don't know if anyone uses kepctl on a Raspberry Pi or a similar device 😅)

Wondering if we should add darwin/arm64 as well? Many folks are moving to ARM Macs, although I don't have any metrics to prove the same.

[palnabarun]

As an addition, I am feeling like we should expose an env var which let's users the flexibility with specifying what they want to build for. Maybe $PLATFORM itself?

[ehashman]

Let's keep darwin/amd64, linux/amd64 and possibly linux/arm64. (don't know if anyone uses kepctl on a Raspberry Pi or a similar device 😅)

Raspis are armhf or 32-bit ARM so this is N/A :) Most arm64 devices are servers, we probably can skip it. But we should probably keep Windows.

[rikatz]

I wouldn't add darwin/arm64 as it wasn't there and no one actually missed it :P

But anyway keeping darwin/amd64, linux/amd64 and windows/amd64 only is already a win.

About adding the variable, I'm not against it, just wondering if we want this to be a multi arg variable, or if a single one (like BUILD_PLATFORM=$1) and verify if this is not empty, use it otherwise use the pre-populated PLATFORMS.

WDYT?

[palnabarun]

Raspis are armhf or 32-bit ARM so this is N/A :)

Ah! E_TOO_MANY_ARCHS 😅

I wouldn't add darwin/arm64 as it wasn't there and no one actually missed it :P

LOL. Makes sense! If someone wants to, we can add later.

About adding the variable, I'm not against it, just wondering if we want this to be a multi arg variable, or if a single one (like BUILD_PLATFORM=$1) and verify if this is not empty, use it otherwise use the pre-populated PLATFORMS.

The best option is a multi-arg variable, then a single variable with comma-separated values. I'm fine with either option. Also, pondering more over it, I'm thinking we can lazily add this feature if someone needs it in future.

[rikatz]

sounds good to me :D

Let me push with darwin/amd64 and windows/amd64 and let me know if you want me to change anything else here :D

[palnabarun]

All okay from my side. Thank you for the changes!

[ehashman]

I noticed the same thing today, 👍

[palnabarun]

Let's keep darwin/amd64, linux/amd64 and possibly linux/arm64. (don't know if anyone uses kepctl on a Raspberry Pi or a similar device 😅)

Wondering if we should add darwin/arm64 as well? Many folks are moving to ARM Macs, although I don't have any metrics to prove the same.

[palnabarun]

As an addition, I am feeling like we should expose an env var which let's users the flexibility with specifying what they want to build for. Maybe $PLATFORM itself?

[rikatz]

/label tide/merge-method-squash

because I'm too lazy to rebase :P

[palnabarun]

/lgtm

[palnabarun]

/assign @jeremyrickard for approval

[k8s-ci-robot]

@palnabarun: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jeremyrickard for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justaugustus]

Thank you!
/lgtm
/approve

[justaugustus]

/assign @johnbelamaric

[johnbelamaric]

/approve
/lgtm

[ehashman]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, johnbelamaric, justaugustus, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [johnbelamaric,justaugustus]
• keps/OWNERS [johnbelamaric,justaugustus]
• keps/prod-readiness/OWNERS [ehashman,johnbelamaric]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment