Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Windows HostProcess container KEP for v1.22 alpha release #2659

Merged
merged 1 commit into from
May 4, 2021
Merged

Updating Windows HostProcess container KEP for v1.22 alpha release #2659

merged 1 commit into from
May 4, 2021

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

Updating milestones for Windows HostProcess container alpha release.
This KEP was approved for v1.21 but implementation PRs did not merge before code freeze so this is slipping into v1.22 release

@marosset
Updating Windows HostProcess container KEP for v1.22 alpha release
3b30c46 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2021
@marosset
Copy link
Contributor Author

/sig windows
/assign @jsturtevant
/hold
Holding in case any other updates are needed based on review feedback for kubernetes/kubernetes#99576

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@marosset marosset mentioned this pull request Apr 29, 2021
Closed
35 tasks
@marosset
Copy link
Contributor Author

marosset commented May 4, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021
@jsturtevant
Copy link
Contributor

The remaining open issue regarding prod-readiness was closed this week and the conclusion was to keep rejection in validation and not drop fields so no other changes required here. Discussion: https://kubernetes.slack.com/archives/CPNHUMN74/p1619719023028700

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit a9902b6 into kubernetes:master May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@marosset @k8s-ci-robot @jsturtevant