Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1933: Update to 'stable' #2847

Merged
merged 3 commits into from
Sep 2, 2021
Merged

KEP-1933: Update to 'stable' #2847

merged 3 commits into from
Sep 2, 2021

Conversation

PurelyApplied
Copy link
Contributor

  • One-line PR description: Update KEP-1933 state to 'stable'
  • Other comments: Also clarify some of the KEP's phrasing and extend Implementation History references.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/security Categorizes an issue or PR as relevant to SIG Security. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2021
@PurelyApplied
Copy link
Contributor Author

Adding from Slack conversation for prod readiness.

/assign deads2k

@deads2k
Copy link
Contributor

deads2k commented Aug 3, 2021

I remember this one, it was a testing tool for CI, not production code. PRR is fine

/approve

@tabbysable
Copy link
Member

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, PurelyApplied, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@ehashman
Copy link
Member

ehashman commented Sep 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6944420 into kubernetes:master Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 2, 2021
@PurelyApplied PurelyApplied mentioned this pull request Sep 3, 2021
Merged
ravisantoshgudimetla pushed a commit to ravisantoshgudimetla/enhancements that referenced this pull request Sep 9, 2021
@PurelyApplied @ravisantoshgudimetla
KEP-1933: Update to 'stable' (kubernetes#2847)
309261f 
* KEP-1933: Update KEP to 'stable'

* Uncomment PRR approval.

* Correct ToC.
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanColdwater IanColdwater Awaiting requested review from IanColdwater

@tabbysable tabbysable Awaiting requested review from tabbysable

Assignees

@ehashman ehashman

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
5 participants
@PurelyApplied @deads2k @tabbysable @k8s-ci-robot @ehashman