-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1591: Fix default values for MaxUnavailable and MaxSurge #3032
Conversation
The implementation defines the default value for MaxSurge being 0, as to preserve the current behavior of rolling updates in DaemonSets. Also, for MaxUnavailable, the rounding is up. This change is just a copy-paste of the docblock defined in the types.go file. See: - https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/types.go - https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/v1/defaults.go#L87-L91
Welcome @renan! |
Hi @renan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
Thanks for updating these :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renan, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The implementation defines the default value for MaxSurge being 0, as to
preserve the current behavior of rolling updates in DaemonSets. Also,
for MaxUnavailable, the rounding is up.
This change is just a copy-paste of the docblock defined in the types.go
file.
See: