Update Efficient Watch Resumption KEP to Stable #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/api-machinery
k8s-ci-robot
added
the
kind/kep
wojtek-t
commented
Nov 29, 2021
| - Rolling-upgrade of kube-apiservers in 5k-node cluster test is | ||
| automated and running periodically. | ||
| - Benefits of the feature during rolling upgrade of kube-apiserver at scale | ||
| (thousands of nodes) proven in production |
There was a problem hiding this comment.
We still aren't testing HA clusters in upstream. Given that it will take more time (we're still trying to converge on what exact framework we should be using) and the fact that:
- we're somewhat-continuously testing it as prt of GKE
- we've already seen a proven effect/benefit from it on real production clusters
I don't want to block GA-ing this feature on that.
wojtek-t
force-pushed
the
efficient_watch_resumption_ga
branch
from
b26f07a to
144ec1b
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1904
/sig api-machinery
/assign @deads2k @lavalamp