Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP - Promote PodOS field to beta #3102

Merged
merged 3 commits into from
Jan 19, 2022
Merged

KEP - Promote PodOS field to beta #3102

merged 3 commits into from
Jan 19, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

  • One-line PR description:
    Promote PodOS field to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2022
@ravisantoshgudimetla ravisantoshgudimetla changed the title Promote PodOS field to beta [WIP] Promote PodOS field to beta Jan 3, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Jan 3, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2022
@ravisantoshgudimetla ravisantoshgudimetla changed the title [WIP] Promote PodOS field to beta Promote PodOS field to beta Jan 5, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

/sig windows

@liggitt @marosset @jsturtevant @jayunit100

@liggitt
Copy link
Member

liggitt commented Jan 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@marosset
Copy link
Contributor

marosset commented Jan 5, 2022

/lgtm

@marosset
Copy link
Contributor

marosset commented Jan 5, 2022

/assign @deads2k
For PRR

@liggitt liggitt modified the milestone: v1.24 Jan 18, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2022
@marosset marosset mentioned this pull request Jan 18, 2022
Closed
26 tasks
@liggitt
Copy link
Member

liggitt commented Jan 19, 2022

this lgtm... any other pending updates / approvals?

@marosset
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
@deads2k
Copy link
Contributor

deads2k commented Jan 19, 2022

lgtm, thanks for the added detail

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, marosset, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 35c7682 into kubernetes:master Jan 19, 2022
@marosset marosset changed the title Promote PodOS field to beta KEP - Promote PodOS field to beta Feb 24, 2022
@tengqm tengqm mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@marosset marosset marosset left review comments

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@liggitt liggitt

@deads2k deads2k

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@ravisantoshgudimetla @liggitt @marosset @deads2k @k8s-ci-robot