Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource constraints for CEL #3144

Merged
merged 20 commits into from
Feb 3, 2022
Merged

Add resource constraints for CEL #3144

merged 20 commits into from
Feb 3, 2022

Commits on Jan 13, 2022

  1. Add initial info on CEL resource constraints.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ae09cbb View commit details
    Browse the repository at this point in the history

  2. Reword to imply depth limiting is just an option.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    16283e1 View commit details
    Browse the repository at this point in the history

  3. Move resource constraint timeout to the top.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    11be065 View commit details
    Browse the repository at this point in the history

  4. Add link to CEL cost subsystem code.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    eea4fd8 View commit details
    Browse the repository at this point in the history

  5. Change timeout from per-expression to per-request.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ff38644 View commit details
    Browse the repository at this point in the history

  6. Move paragraph on cost subsystem to the end.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    efda13f View commit details
    Browse the repository at this point in the history

  7. Change CEL expression timeout to 5 seconds.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    fa0b979 View commit details
    Browse the repository at this point in the history

  8. Change text that was out-of-date after reformatting.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    bf2b434 View commit details
    Browse the repository at this point in the history

  9. Note that the timeout message will include evaluation time.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    76e4605 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Specifcy that Beta timeout will be 100ms-1s.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e4b49ba View commit details
    Browse the repository at this point in the history

  2. Run hack/update-toc.sh.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8bd777a View commit details
    Browse the repository at this point in the history

  3. Clarify that Beta performance will be tested against benchmarks.

    @DangerOnTheRanger
    DangerOnTheRanger committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e541ae3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Prepare for final review.

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    6a550cb View commit details
    Browse the repository at this point in the history

  2. Run hack/update-toc.sh

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    ac9e0e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Update in response to feedback.

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4e440b0 View commit details
    Browse the repository at this point in the history

  2. Remove per-expression timeout, make per-request timeout sourced from … 

    …request context.
    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    3e36b22 View commit details
    Browse the repository at this point in the history

  3. Add runtime cost check.

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    8736077 View commit details
    Browse the repository at this point in the history

  4. Run hack/update-toc.sh

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    49fe807 View commit details
    Browse the repository at this point in the history

  5. Minor fixes with APF wording.

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5f96b1c View commit details
    Browse the repository at this point in the history

  6. Keep cost bounds as future work.

    @DangerOnTheRanger
    DangerOnTheRanger committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5f44379 View commit details
    Browse the repository at this point in the history