Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3107: SecretRef field addition to NodeExpandVolume request #3173

Merged
merged 1 commit into from
Feb 1, 2022
Merged

KEP-3107: SecretRef field addition to NodeExpandVolume request #3173

merged 1 commit into from
Feb 1, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 21, 2022

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 21, 2022
@humblec humblec force-pushed the nodeexpand branch 2 times, most recently from 8bdafca to 80d9656 Compare January 21, 2022 17:33
@msau42
Copy link
Member

msau42 commented Jan 22, 2022

Can you also add the PRR file so we can get a PRR reviewer?

@xing-yang
Copy link
Contributor

@humblec Can you remove ".md" from the middle part of the directory "3107-csi-nodeexpandsecret.md" and rename 3107-csi-nodeExpandSecret.md to README.md? See this example here:
https://github.com/kubernetes/enhancements/pull/3124/files

@humblec humblec force-pushed the nodeexpand branch 3 times, most recently from 1135788 to dbdc267 Compare January 24, 2022 09:02
@humblec
Copy link
Contributor Author

humblec commented Jan 24, 2022

Can you also add the PRR file so we can get a PRR reviewer?

Added PRR file @msau42 , ptal..

@humblec
Copy link
Contributor Author

humblec commented Jan 24, 2022

@humblec Can you remove ".md" from the middle part of the directory "3107-csi-nodeexpandsecret.md" and rename 3107-csi-nodeExpandSecret.md to README.md? See this example here: https://github.com/kubernetes/enhancements/pull/3124/files

Sure, the file name schema is corrected . thanks @xing-yang

@humblec humblec requested a review from msau42 January 24, 2022 13:20
@humblec
Copy link
Contributor Author

humblec commented Jan 24, 2022

Cc @gnufied

@msau42
Copy link
Member

msau42 commented Jan 24, 2022

@humblec the PRR file is still missing. See https://github.com/kubernetes/enhancements/pull/3151/files as an example.

@humblec
Copy link
Contributor Author

humblec commented Jan 25, 2022 •
edited
Loading

@humblec the PRR file is still missing. See https://github.com/kubernetes/enhancements/pull/3151/files as an example.

Sure, added. Thanks @msau42 .. ptal.

@msau42
Copy link
Member

msau42 commented Jan 25, 2022

/assign @deads2k

@humblec humblec force-pushed the nodeexpand branch 5 times, most recently from 7eb5e32 to b50ac0d Compare January 25, 2022 06:18
@humblec humblec force-pushed the nodeexpand branch 3 times, most recently from f652415 to be97117 Compare January 25, 2022 07:03
@humblec
KEP-3107: SecretRef field addition to NodeExpandVolume request
f4653c5 
Issue kubernetes#3107

Other comments: Prototype with working implementation
kubernetes/kubernetes#105963

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@msau42
Copy link
Member

msau42 commented Jan 27, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
deads2k
deads2k reviewed Feb 1, 2022
View reviewed changes
keps/sig-storage/3107-csi-nodeexpandsecret/README.md

TBD

### Monitoring Requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not required for alpha, I encourage you to think about what metrics you'll need to build for beta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure , Thanks @deads2k 👍

@deads2k
Copy link
Contributor

deads2k commented Feb 1, 2022

monitoring and troubleshooting are often the hardest parts to fill in for a transition to beta. I encourage you to think about how you will handle it during your alpha.

PRR is complete for alpha

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, humblec, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit e693612 into kubernetes:master Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 1, 2022
@rhockenbury rhockenbury mentioned this pull request Feb 3, 2022
Closed
12 tasks
@humblec humblec mentioned this pull request Mar 16, 2022
Closed
@zhucan zhucan mentioned this pull request Mar 16, 2022
Merged
@humblec humblec mentioned this pull request Apr 5, 2022
Closed
@humblec humblec mentioned this pull request May 27, 2022
Merged
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
csi: add nodeExpandSecret KEP details
11346ca 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#32450

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
si: add nodeExpandSecret KEP details
7ab3fd5 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#32450

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec mentioned this pull request Jul 25, 2022
Merged
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
csi: add nodeExpandSecret KEP details
a604d62 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#33979

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
csi: add nodeExpandSecret KEP details
bbc8680 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#33979

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Aug 1, 2022
@humblec
csi: add nodeExpandSecret KEP details
2c306bc 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#33979

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@deads2k deads2k deads2k left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@deads2k deads2k

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@humblec @msau42 @xing-yang @deads2k @k8s-ci-robot