Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Portworx CSI migration to Beta in v1.24 #3187

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Promote Portworx CSI migration to Beta in v1.24 #3187

merged 1 commit into from
Feb 1, 2022

Conversation

trierra
Copy link
Contributor

@trierra trierra commented Jan 26, 2022

This commit adds the details to the KEP for promoting Portworx CSI migration from alpha to beta in v1.24

One-line PR description: Update KEP for Portworx CSI Migration

Issue link: Portworx file in-tree to CSI driver migration #2589

Other comments:

/sig storage
/cc @msau42

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @trierra!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @trierra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 26, 2022
@trierra trierra mentioned this pull request Jan 26, 2022
Open
12 tasks
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2022
@xing-yang
Copy link
Contributor

/assign @msau42 @Jiawei0227

@msau42
Copy link
Member

msau42 commented Jan 27, 2022

This is missing updates to https://github.com/kubernetes/enhancements/blob/389e229182de11f7fc81369d2051369bcb8c786a/keps/prod-readiness/sig-storage/2589.yaml. Can you add @wojtek-t as PRR reviewer?

/assign @wojtek-t

@trierra trierra requested a review from wojtek-t January 28, 2022 19:12
msau42
msau42 reviewed Jan 28, 2022
View reviewed changes
keps/prod-readiness/sig-storage/2589.yaml
@@ -1,3 +1,3 @@
kep-number: 2589
alpha:
beta:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the alpha entry and add a new beta entry with @wojtek-t as the reviewer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, let me fix that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - as Michelle wrote. Please don't change the existing entries - just add a new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t done

@msau42
Copy link
Member

msau42 commented Jan 28, 2022

/approve

@trierra
Promote Portworx CSI migration to Beta in v1.24
7d4aa34 
This commit adds the details to the KEP for promoting Portworx CSI migration from alpha to beta in v1.24
@trierra trierra requested a review from msau42 February 1, 2022 02:01
@msau42
Copy link
Member

msau42 commented Feb 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2022

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, trierra, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 769d2a8 into kubernetes:master Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@msau42 msau42 Awaiting requested review from msau42

Assignees

@wojtek-t wojtek-t

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@trierra @k8s-ci-robot @xing-yang @msau42 @wojtek-t @Jiawei0227