KEP-1435: adding PRR for MixedProtocolLBService feature to move to beta

[bridgetkromhout]

• One-line PR description:

Adding Production Readiness Review for Mixed Protocols in Services with type=LoadBalancer

• Issue link: Support of mixed protocols in Services with type=LoadBalancer #1435

• Other comments:

Have discussed with SIG-network and SIG-cloudprovider; see #1435 (comment) for details.

Signed-off-by: Bridget Kromhout bridget@kromhout.org

[thockin]

LGTM for content, but I am not PRR.

[andrewsykim]

Overall +1 from me, shifting the validation for protocols out of apiserver validation and into provider-specific implementations makes sense.

There's a future optimization we can also propose in the future, where instead of defering to cloud provider controllers to validation protocols, they can run external validation webhooks against Service. We might even be able to re-use work from this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2699-add-webhook-hosting-to-ccm

[bridgetkromhout]

/assign @thockin @ehashman

[thockin]

/lgtm

[thockin]

Thanks!

/lgtm
/approve

[ehashman]

@aojea thanks for your replies, please update the KEP/PRR questionnaire with these answers

[bridgetkromhout]

@aojea thanks for your replies, please update the KEP/PRR questionnaire with these answers

Thanks, @ehashman! I've incorporated the feedback from you and @aojea into my latest update; please review and let us know what additional edits (if any) are needed.

[ehashman]

Awesome, thank you!

/lgtm
/approve
for PRR

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bridgetkromhout, ehashman, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS [ehashman]
• keps/sig-network/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

Awesome, thank you!

/lgtm /approve for PRR

Thanks Elana 👏